Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default downloading timeout configurable? #491

Open
pcmid opened this issue Nov 4, 2023 · 1 comment
Open

Make default downloading timeout configurable? #491

pcmid opened this issue Nov 4, 2023 · 1 comment
Labels
download enhancement

Comments

@pcmid
Copy link

pcmid commented Nov 4, 2023

When downloading file without timeout_ms, the default timeout will be calculated and set to 20s. It is not enough for downloading large file.

I checked the docs and codes and found this, timeouts. It seems that we could not set it. Could we add an option to make the default downloading timeout configurable

https://github.com/turt2live/matrix-media-repo/blob/209d91b10e9395dd6b8f628a477beb71091ecde5/api/r0/download.go#L57-L60
https://github.com/turt2live/matrix-media-repo/blob/209d91b10e9395dd6b8f628a477beb71091ecde5/util/time.go#L16-L33
@turt2live
Copy link
Member

Clients can request a longer timeout as per the Matrix specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
download enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @pcmid