Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawing issues on Mapbox #18

Closed
andreschardonguwo opened this issue Mar 12, 2017 · 10 comments
Closed

drawing issues on Mapbox #18

andreschardonguwo opened this issue Mar 12, 2017 · 10 comments

Comments

@andreschardonguwo
Copy link

T-rex is awesome. Everything seems to be working very well. However i'm having some issues with high-level zoom (above 12). I'm attaching a few screenshots. Was wondering if it was an issue with zoom level. But not sure

t-rex-pol-lines-more-erros
t-rex-pol-lines
t-rex-pol-ok

@pka
Copy link
Member

pka commented Mar 13, 2017

Looks strange indeed! Are these maps rendered with a built-in viewer? Which version?

@andreschardonguwo
Copy link
Author

I'm trying with the latest version 0.33.1. However, happens on the built in as well. Also noticed that no issues with built in OpenLayers and XRay

@pka
Copy link
Member

pka commented Mar 13, 2017

Then I'm supecting degerated geometries caused by clipping or simplification (see #5). Can you turn off simplification and play with the clipping parameters? I'm very interested in a dataset working with OL, but not with MB GL js. Is your datasource public or can you make it available for testing?

@andreschardonguwo
Copy link
Author

Thank's for the reply. I will test without simplification later today. I also can share this dataset. It's a query on our postgis server. However, I can export as shape file or geojson.

@andreschardonguwo
Copy link
Author

Tried to remove clipping and simplification = false, and the result is the same. Some polygons have holes. Maybe that's the issue. However, on OL they are correctly drawn. I can send you the dataset. What's the best format?

@pka
Copy link
Member

pka commented Mar 14, 2017

Best option would be a PG dump (pg_dump --file=out.dump --format=c --table=...). A file export would maybe do it as well.

@andreschardonguwo
Copy link
Author

Find attached the dump file. Let me know if you able to test it. Thank you very much!.

out.zip

@pka
Copy link
Member

pka commented Mar 15, 2017

Thanks for the data. I couldn't reproduce your output, but also saw some glitches when displaying it with Maputnik. A first look at the data shows some invalid geometries:

gid st_npoints st_nrings st_isvaliddetail
162620 16348 11 (t,,)
162621 17451 9 (t,,)
162622 16006 6 (t,,)
162623 11674 8 (t,,)
162624 809 1 (t,,)
162625 12193 1 (t,,)
162626 22191 14 (f,"Too few points in geometry component",0101000000FBA45F828DCA53C1BED636691E7644C1)
162627 14718 2 (t,,)
162628 8661 2 (t,,)
162629 11419 9 (f,"Too few points in geometry component",01010000002E4D0730DEDB53C10198F0D8160045C1)
162630 8195 5 (f,"Too few points in geometry component",0101000000417405DD7AE553C132B7F7E9B3DC44C1)
162631 8441 9 (t,,)
162632 12311 4 (t,,)
162633 5055 1 (t,,)
162634 27981 10 (t,,)
162635 10026 2 (t,,)
162636 6761 2 (t,,)
162637 5083 1 (t,,)
162638 2663 1 (t,,)
162639 3961 1 (t,,)
162640 2929 1 (t,,)
162641 5122 1 (t,,)
162642 2513 1 (t,,)
162643 20223 10 (f,"Too few points in geometry component",010100000046B04456ECE453C1926402CE9EA644C1)
162644 6420 3 (t,,)
162645 3559 1 (t,,)
162646 2835 1 (t,,)

@andreschardonguwo
Copy link
Author

Thank you @pka. I've published the layer and removed the invalid geometries, however, mabox still is drawing the lines. OpenLayers still fine.

img2
img1

@pka
Copy link
Member

pka commented Jun 14, 2017

These artifacts are caused by unclipped polygons or lines. Clipping has been fixed for reprojected layers in 7801bb8 and in a6889b7 for config files written with version 0.7.2.
Always use buffer_size in your configuration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants