diff --git a/src/Internal/Frame/DataRow.php b/src/Internal/Frame/DataRow.php index bdd9aee..9e92835 100644 --- a/src/Internal/Frame/DataRow.php +++ b/src/Internal/Frame/DataRow.php @@ -17,14 +17,14 @@ public function __construct(array $keys, array $assoc, array $values) $this->values = $values; } - public static function empty(): DataRow + public static function of(array $values): DataRow { - return new self([], [], []); + return new DataRow($values, \array_fill(0, \count($values), true), $values); } - public static function associative($key, array $values): DataRow + public static function dictionaryEntry($key, $value): DataRow { - return new DataRow([$key], [true], $values); + return new DataRow([$key], [true], [$value]); } public function isAssociative(int $index): bool @@ -42,7 +42,6 @@ public function joined(DataRow $dataRow): DataRow return new DataRow( \array_merge($this->keys, $dataRow->keys), \array_merge($this->associative, $dataRow->associative), - \array_merge($this->values, $dataRow->values) - ); + \array_merge($this->values, $dataRow->values)); } } diff --git a/src/Internal/Provider/DictionaryProvider.php b/src/Internal/Provider/DictionaryProvider.php index 3704bf9..6bafed1 100644 --- a/src/Internal/Provider/DictionaryProvider.php +++ b/src/Internal/Provider/DictionaryProvider.php @@ -18,7 +18,7 @@ protected function dataset(): array { $dataset = []; foreach ($this->dictionary as $key => $value) { - $dataset[] = DataRow::associative($key, [$value]); + $dataset[] = DataRow::dictionaryEntry($key, $value); } return $dataset; } diff --git a/src/Internal/Provider/DistinctPairsProvider.php b/src/Internal/Provider/DistinctPairsProvider.php index 4c2aae1..d0a8939 100644 --- a/src/Internal/Provider/DistinctPairsProvider.php +++ b/src/Internal/Provider/DistinctPairsProvider.php @@ -22,7 +22,7 @@ protected function dataset(): array if ($index1 === $index2) { continue; } - $dataset[] = new DataRow([$augend, $addend], [true, true], [$augend, $addend]); + $dataset[] = DataRow::of([$augend, $addend]); } } return $dataset; diff --git a/src/Internal/Provider/EntriesProvider.php b/src/Internal/Provider/EntriesProvider.php index d3a5592..0a6565a 100644 --- a/src/Internal/Provider/EntriesProvider.php +++ b/src/Internal/Provider/EntriesProvider.php @@ -18,7 +18,7 @@ protected function dataset(): array { $dataset = []; foreach ($this->dictionary as $key => $value) { - $dataset[] = new DataRow([$key, $value], [true, true], [$key, $value]); + $dataset[] = DataRow::of([$key, $value]); } return $dataset; } diff --git a/src/Internal/Provider/ListProvider.php b/src/Internal/Provider/ListProvider.php index 0ac4474..6886516 100644 --- a/src/Internal/Provider/ListProvider.php +++ b/src/Internal/Provider/ListProvider.php @@ -18,7 +18,7 @@ protected function dataset(): array { $dataset = []; foreach ($this->values as $value) { - $dataset[] = DataRow::associative($value, [$value]); + $dataset[] = DataRow::of([$value]); } return $dataset; } diff --git a/src/Internal/Provider/PairsProvider.php b/src/Internal/Provider/PairsProvider.php index e8f8e53..fcac060 100644 --- a/src/Internal/Provider/PairsProvider.php +++ b/src/Internal/Provider/PairsProvider.php @@ -19,7 +19,7 @@ protected function dataset(): array $dataset = []; foreach ($this->values as $augend) { foreach ($this->values as $addend) { - $dataset[] = new DataRow([$augend, $addend], [true, true], [$augend, $addend]); + $dataset[] = DataRow::of([$augend, $addend]); } } return $dataset; diff --git a/src/Internal/Provider/TuplesProvider.php b/src/Internal/Provider/TuplesProvider.php index eb81a2f..8c88052 100644 --- a/src/Internal/Provider/TuplesProvider.php +++ b/src/Internal/Provider/TuplesProvider.php @@ -18,7 +18,7 @@ protected function dataset(): array { $dataset = []; foreach ($this->sets as $set) { - $dataset[] = new DataRow($set, \array_fill(0, \count($set), true), $set); + $dataset[] = DataRow::of($set); } return $dataset; } diff --git a/src/Internal/Provider/ZipProvider.php b/src/Internal/Provider/ZipProvider.php index e4b8d2a..bcfd85e 100644 --- a/src/Internal/Provider/ZipProvider.php +++ b/src/Internal/Provider/ZipProvider.php @@ -67,7 +67,7 @@ private function count(): int private function zippedRow(int $rowIndex): DataRow { - $joinedRow = DataRow::empty(); + $joinedRow = DataRow::of([]); foreach ($this->dataFrames as $dataProvider) { $joinedRow = $joinedRow->joined($dataProvider->dataset()[$rowIndex]); } diff --git a/test/Fixture/HistoryDataProvider.php b/test/Fixture/HistoryDataProvider.php index dc9b7fe..005afb1 100644 --- a/test/Fixture/HistoryDataProvider.php +++ b/test/Fixture/HistoryDataProvider.php @@ -29,7 +29,7 @@ private function arrayDatasets(): array { $datasets = []; foreach ($this->elements as $key => $value) { - $datasets[] = DataRow::associative($key, [$value]); + $datasets[] = DataRow::dictionaryEntry($key, $value); } return $datasets; }