Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TEMPLATEPATH, STYLESHEETPATH, and WP_DEFAULT_THEME constants #175

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

westonruter
Copy link
Contributor

@szepeviktor
Copy link
Owner

szepeviktor commented Apr 8, 2023

I'd like to encourage core function usage.
Plugins rarely read these constants. So I do not merge this one.
Sorry.

@szepeviktor szepeviktor closed this Apr 8, 2023
@szepeviktor
Copy link
Owner

szepeviktor commented Apr 8, 2023

@westonruter
Copy link
Contributor Author

westonruter commented Apr 9, 2023

I'm not sure I would characterize usage as rare: https://wpdirectory.net/search/01GXJ8VAEHKDYT46ATAV25475Q

@szepeviktor
Copy link
Owner

Yes you are right.
I say using globals has no part in a software. But we have WordPress.
This is all I can offer.

If I would be a WordPress promoter, all core globals would be part of this project.

@westonruter
Copy link
Contributor Author

I guess I misunderstood your motivations for this project.

@szepeviktor szepeviktor reopened this Apr 9, 2023
@szepeviktor
Copy link
Owner

szepeviktor commented Apr 9, 2023

I've realized I should support the WordPress ecosystem even if I cannot tolerate its code quality.
Please see the What to avoid list https://github.com/szepeviktor/starter-plugin#what-to-avoid

@szepeviktor szepeviktor merged commit 51a29b6 into szepeviktor:master Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants