Skip to content

Ensure Sqeuential Link Sequence #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siforf564 opened this issue Feb 26, 2024 · 2 comments · Fixed by #499
Closed

Ensure Sqeuential Link Sequence #492

siforf564 opened this issue Feb 26, 2024 · 2 comments · Fixed by #499
Assignees
Labels
bug Something isn't working done

Comments

@siforf564
Copy link
Contributor

Link Sequence does not seems to stay sequential.

Exemple in quetzal-hfr >> BUG >> ott-tor-omni_oak_0
where link_sequence starts at 3 and jump from 4 to 6.

This trip have been created from a copy and by removing nodes which may have led to this problem

@siforf564 siforf564 added the bug Something isn't working label Feb 26, 2024
@sboivinsystra
Copy link
Contributor

sboivinsystra commented Feb 27, 2024

I don't fully understand how this happen.

However. editor_links are now sorted (with link sequence) when entering edition mode. non sorted links could have created the problem as deleting nodes assume that the links are sorted when changing link_sequence.

Cloning trips also assumed it was sorted which was problematic.

note: cloning trips will start at link_sequence=1 and increase by 1

@sboivinsystra
Copy link
Contributor

5.2.f

@sboivinsystra sboivinsystra linked a pull request Mar 21, 2024 that will close this issue
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants