Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "scenario" parameters in step model inputs #393

Closed
siforf564 opened this issue Aug 1, 2023 · 3 comments · Fixed by #394
Closed

Remove "scenario" parameters in step model inputs #393

siforf564 opened this issue Aug 1, 2023 · 3 comments · Fixed by #394
Assignees
@sboivinsystra
Labels
done
Milestone
4.9

Comments

@siforf564
Copy link
Contributor

We should let the model choose its default scenrio to use

https://github.com/systragroup/quetzal-network-editor/blob/1796017be705e76451015cbae50c06351fe5c209/src/store/api/run.js#L134C14-L134C30
@sboivinsystra
Copy link
Contributor

will this break the dockers?

@siforf564
Copy link
Contributor Author

Not supposed to. As it is not used in main.py and notebook have default values for scenario

@sboivinsystra sboivinsystra linked a pull request Aug 1, 2023 that will close this issue
remove scenario from payload #394
Merged
@sboivinsystra
Copy link
Contributor

4.8.c

@sboivinsystra sboivinsystra reopened this Aug 1, 2023
@sboivinsystra sboivinsystra added this to the 4.9 milestone Aug 18, 2023
@sboivinsystra sboivinsystra self-assigned this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sboivinsystra sboivinsystra

Labels
done
Projects
None yet
Milestone
4.9
Development

Successfully merging a pull request may close this issue.

remove scenario from payload systragroup/quetzal-network-editor
2 participants
@siforf564 @sboivinsystra