Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enotice on settings form #9

Open
eileenmcnaughton opened this issue Nov 5, 2018 · 3 comments
Open

enotice on settings form #9

eileenmcnaughton opened this issue Nov 5, 2018 · 3 comments
Milestone
1.3

Comments

@eileenmcnaughton
Copy link

I haven't double checked but I was checking settings in conjunction with civicrm/civicrm-core#13048 & I'm pretty sure you will have an enotice on yours as $_settings is not defined - I would recommend changing from extends CRM_Admin_Form_Setting to just CRM_Core_Form - you are not really using functionality from the settings form and it's not really supported as an integration point - I think it could well be completely deleted in the future
@eileenmcnaughton eileenmcnaughton mentioned this issue Nov 5, 2018
Merged
@bjendres bjendres added this to the 1.2 milestone Nov 5, 2018
@bjendres
Copy link
Member

bjendres commented Nov 5, 2018

Thanks, @eileenmcnaughton, great initiative! I feel like I haven't looked at this code in ages....

@eileenmcnaughton
Copy link
Author

@systopia sometimes looking at old code can be traumatic .....

@bjendres
Copy link
Member

bjendres commented Nov 5, 2018

@systopia sometimes looking at old code can be traumatic .....

Indeed

@bjendres bjendres modified the milestones: 1.2, 1.3 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@eileenmcnaughton @bjendres