Upgrade peer dependencies & Remove old styles #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 58.22% 58.14% -0.08%
==========================================
Files 136 137 +1
Lines 3835 3847 +12
Branches 678 683 +5
==========================================
+ Hits 2233 2237 +4
- Misses 1489 1494 +5
- Partials 113 116 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jferrer1W
previously approved these changes
Oct 21, 2025
carlosra85
requested changes
Oct 21, 2025
| { | ||
| "name": "systelab-components", | ||
| "version": "20.0.2", | ||
| "version": "20.0.3", |
| ``` | ||
| All values defined in Bootstrap [_variables.scss](https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss) and systelab-components [_variables.scss](sass/_variables.scss) (classic style) or [_variables.scss](sass/modern/_variables.scss) (modern style) can be overwritten. |
README.md
Outdated
| - Polishing developer experience with style guide updates. | ||
| - Advancements in GenAI development with llms.txt and angular.dev guides and videos for building Generative AI applications | ||
| - Launching a request for comments for an official mascot for Angular | ||
| - Since v20.0.3 the old styles has been removed and now the modern styles are the only ones, so the import of the styles must be updated without the modern path `@import "systelab-components/sass/systelab-components";` |
carlosra85
previously approved these changes
Oct 21, 2025
jferrer1W
previously approved these changes
Oct 21, 2025
fjaguado
previously approved these changes
Oct 21, 2025
package.json
Outdated
| "@angular/router": "20.1.3", | ||
| "@ngx-translate/core": "16.0.4", | ||
| "@ngx-translate/http-loader": "16.0.1", | ||
| "@primeuix/themes": "^1.2.5", |
There was a problem hiding this comment.
Don't use caret. We want to control which version are installed
package.json
Outdated
| "popper.js": "1.16.1", | ||
| "primeicons": "7.0.0", | ||
| "primeng": "17.18.15", | ||
| "primeng": "^20.2.0", |
There was a problem hiding this comment.
Don't use caret. We want to control which version are installed
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "20.1.2", | ||
| "@angular-devkit/build-angular": "^20.3.4", |
There was a problem hiding this comment.
Don't use caret. We want to control which version are installed
amilaWerfen
dismissed stale reviews from fjaguado, jferrer1W, and carlosra85
via
54f3e1e
carlosra85
approved these changes
Oct 22, 2025
msolis9
approved these changes
Oct 22, 2025
oshura
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
We have upgraded the peer dependencies of primeNG in the showcase and we have also update the library to fix visualizations issues related to the angular upgraded version
Description
Previously, the showcase was working with the v17 of primeNG meanwhile the Systelab components was at v20 and was generating a working version but with missmatch between the versions.
Related Issue
#1034
Motivation and Context
Not using the correct version of primeNG was making us to force builds and npm update to work with systelab components and if you tried to use the v20 of primeNG on our v20 of systelab-components It was generating some errors.
How Has This Been Tested
We have tested in local, using the show-case and executing the automatic tests.
Types of changes
Checklist