Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix missing tag override #53

Closed

Conversation

Privatecoder
Copy link

What type of PR is this?
/kind bug

What this PR does / why we need it:

tag in ccm-hetzner v1.1.5 values.yaml is empty so image-pulling fails for version 1.13.2-0.0.1 as quay.io only holds v-prefixed-images, i.e. v1.13.2-0.0.1.

Which issue(s) this PR fixes

Fixes #52

fill empty tag override due to image being prefixed with `v` in quay.io`s repo but defaults to version number without this prefix
@batistein
Copy link
Contributor

the version in Chart.yaml needs a bump as well. Without increasing the version number no release is triggered

@batistein
Copy link
Contributor

this should be solved in the newest release

@batistein batistein closed this Sep 30, 2023
@Privatecoder Privatecoder deleted the fix-missing-tag-override branch September 30, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Missing tag in hetzner-cloud-controller-manager
2 participants