Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Missing toleration in csi-hcloud DaemonSet #50

Open
Privatecoder opened this issue Mar 9, 2023 · 1 comment
Open

🐛 Missing toleration in csi-hcloud DaemonSet #50

Privatecoder opened this issue Mar 9, 2023 · 1 comment

Comments

@Privatecoder
Copy link

/kind bug

What steps did you take and what happened:

When deploying hetzner csi-hcloud:0.3.1 the resulting DaemonSet pods does not have tolerations set correctly.

Should be:

tolerations:
- effect: NoExecute
  operator: Exists
- effect: NoSchedule
  operator: Exists
- key: CriticalAddonsOnly
  operator: Exists

Is:

tolerations:
- effect: NoExecute
  operator: Exists
- key: CriticalAddonsOnly
  operator: Exists

What did you expect to happen:

Missing toleration should be available

- effect: NoSchedule
  operator: Exists
@Privatecoder
Copy link
Author

Also csi-hcloud-controller does not obey instance.hetzner.cloud/is-root-server as the original hcloud-csi-controller does: https://github.com/hetznercloud/csi-driver/blob/f7271112c825ba94eba92b003284cb924becddab/deploy/kubernetes/hcloud-csi.yml#L118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant