refactor: avoid benchmark role collision with var.name #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wideawakening
requested review from
a team,
haresh-suresh and
nkraemer-sysdig
as code owners
hayk99
approved these changes
Jan 10, 2023
| curl -L "`curl -s https://api.github.com/repos/terraform-linters/tflint/releases/latest | grep -o -E "https://.+?_linux_amd64.zip"`" -o tflint.zip && \ | ||
|
|
||
| # not working- fixme | ||
| # curl -L "`curl -s https://api.github.com/repos/terraform-linters/tflint/releases/latest | grep -o -E "https://.+?_linux_amd64.zip"`" -o tflint.zip && \ |
Contributor
There was a problem hiding this comment.
maybe we can remove this line?
Contributor
Author
There was a problem hiding this comment.
yeah, wanted to wait for @tembleking conversation (internally) but eventually we could :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during a customer escalation we saw that both role and service account conflict due to GCP softdelete + previously existing resource
for single account it was already done, but organizational example lacked the
var.nameprefix insertion on both items.this PR adds both from the example layer.
side-quest
var.nameusage on all examples