fix: terrascan compliance #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
3
to
6
| # Why: Image scanning is run from inside a container. As it needs to get the image from the registry it needs a token to get it from the registry. | ||
| # How to avoid security issues: As in the next implementation scanning will be run from within cloudrun which has needed permissions and won't need a token. | ||
| # Warning: Organization users musn't be able to impersonate as the created service account. | ||
| #ts:skip=AC_GCP_0006 |
Contributor
There was a problem hiding this comment.
non-blocking, but just to enhance understandably, would change order of the comments
ex.:
# AC_GCP_006
# Warning: Organization users musn't be able to impersonate as the created service account.
# Why: Image scanning is run from inside a container. As it needs to get the image from the registry it needs a token to get it from the registry.
# How to avoid security issues: As in the next implementation scanning will be run from within cloudrun which has needed permissions and won't need a token.
#ts:skip=AC_GCP_0006
wideawakening
previously approved these changes
Oct 6, 2022
hayk99
approved these changes
Oct 7, 2022
jprieto92
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Image scanning is run from inside a container. As it needs to get the image from the registry it needs a token to get it from the registry.
How to avoid security issues: As in the next implementation scanning will be run from within cloudrun which has needed permissions and won't need a token.
Warning: Organization users musn't be able to impersonate as the created service account.