fix(bench) Fix sa role binding #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkraemer-sysdig
requested review from
aq17,
hayk99,
nestorsalceda and
wideawakening
aq17
approved these changes
Oct 19, 2021
wideawakening
approved these changes
Oct 20, 2021
Contributor
wideawakening
left a comment
wideawakening
left a comment
There was a problem hiding this comment.
- changed examples
role_nametobenchmark_role_nameand same forbenchmark_regionsfor more context and coherence - updated #44 to reflect current status on collision issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where we were binding the custom role (which includes the
storage.buckets.getIamPolicypermission) to the service account as a resource instead of as an identity. This meant that the service account did not get this permission applied, and was getting 403 errors on certain policies.This PR modifies the bindings to target the service account as an identity.
Also includes a small fix to the task name