Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to Validate Binaries #233

Closed
jordan-rash opened this issue May 20, 2024 · 1 comment · Fixed by #235
Closed

Attempt to Validate Binaries #233

jordan-rash opened this issue May 20, 2024 · 1 comment · Fixed by #235
Assignees
Labels
accepted The defect or proposal as been accepted proposal Enhancement idea or proposal

Comments

@jordan-rash
Copy link
Contributor

Proposed change

We are not currently validating binaries are being deployed to machines that support the binaries architecture. For example, if we attempt to deploy a linux/arm64 binary to a no-sandbox windows node, it will attempt to run it.

This issue proposes we attempt to validate a binary as best we can prior to deployment using the file headers.

Use case

nex run and nex devrun should error if a binary is attempted to run on a machine with a different OS/Arch

Contribution

No response

@jordan-rash jordan-rash added the proposal Enhancement idea or proposal label May 20, 2024
@jordan-rash jordan-rash self-assigned this May 21, 2024
@autodidaddict
Copy link
Contributor

to be more specific, nex run and nex devrun should error because the nex node rejects the run request prior to attempting to run/deploy the executable

@jordan-rash jordan-rash added the accepted The defect or proposal as been accepted label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The defect or proposal as been accepted proposal Enhancement idea or proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants