Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!shaped-apply-defaults overwrites existing token values with blank values #432

Closed
ghost opened this issue Mar 26, 2017 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented Mar 26, 2017

I purchased Yawning Portal and have been trying to convert it cleanly to the Shaped Sheet. The maps include all of the tokens with HP set to bar 1 and AC to bar 2.

When selecting a token and running !shaped-apply-defaults it does apply the proper configuration (hooray!), however it wipes out the existing token values, which means that any token where this command is run needs to be replaced.

@symposion
Copy link
Owner

This appears to be related to: https://bitbucket.org/mlenser/5eshaped/issues/404/bar-linking-not-working-correctly-on I'm still unsure how much of this is sheet vs script - I suspect that the two are arguing somewhere and this is causing the problem.

At least part of the issue is a case sensitivity thing - the OGL uses lower case hp and ac whereas shaped uses upper. I have put in a fix for this for the next version of the script so the bar attribute matching is now case insensitive (the sheet workers are all case insensitive)

@ghost
Copy link
Author

ghost commented Apr 2, 2017

This seems to be resolved with 8.2.1 and/or the sheet 11.3.1, so this can be closed!

@symposion
Copy link
Owner

It's improved, but I suspect that there are cases where it might still happen. I'm currently working on a total rewrite of this stuff based on some new code that Kryx added to the sheet that lets me hook into when all sheetworker processing is completed. This allows me to remove a lot of kludge that I had with the token/character defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant