Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with error code 11 on various keys/combinations #7308

Open
Brynyard opened this issue Dec 10, 2023 · 2 comments
Open

Crash with error code 11 on various keys/combinations #7308

Brynyard opened this issue Dec 10, 2023 · 2 comments
Labels
bug There is an error or the program doesn't work properly triage Awaiting repro confirmation (bug) or needs accepting (enhancement)

Comments

@Brynyard
Copy link

Operating Systems

Server: Win 10
Client: Ubuntu 22.04

Synergy Version

Server: Synergy 1.14.6
Client; Synergy 1.14.6

Steps to Reproduce

  1. Type in '|' (top left on NO_nb keyboard layout) or AltGr+2 (should produce an '@')
  2. Client crash with exit code 11, restarts and reconnects
  3. "Unstick" they control key you held down on the client with an attached keyboard or you'll be in a ton of hurt
@Brynyard Brynyard added the bug There is an error or the program doesn't work properly label Dec 10, 2023
@Brynyard
Copy link
Author

After trying to override the lang value Synergy infers I discovered that a) that ain't possible and b) Synergy seems to assume the keyboard language (KLID) is always the same as the input locale (HKL), ref AppUtilsWindows.cpp:210+. This is probably usually true, but as I write code for a living and given Windows' horribly bad Norwegian translation, I tend to use the english edition of Windows with a Norwegian keyboard (and given all the bug reports about this I'm not alone).

Instead of looking up the national code from the locale using GetKeyboardLayout, please look up the keyboard layout id via the GetKeyboardLayoutName function instead.

@nbolton nbolton added the triage Awaiting repro confirmation (bug) or needs accepting (enhancement) label Jul 16, 2024
@nbolton nbolton added the unanswered Issue not yet been answered by a maintainer label Sep 6, 2024
@nbolton
Copy link
Member

nbolton commented Sep 6, 2024

Thanks for reporting this bug, we will try to reproduce it when we can.

@nbolton nbolton removed the unanswered Issue not yet been answered by a maintainer label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is an error or the program doesn't work properly triage Awaiting repro confirmation (bug) or needs accepting (enhancement)
Projects
None yet
Development

No branches or pull requests

2 participants