Allow to overwrite pre-defined aliases using addAliases() #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Oct 7, 2019
…yrkan) This PR was merged into the master branch. Discussion ---------- Allow to overwrite pre-defined aliases using addAliases() Currently pre-defined aliases (used by `vue` and `preact-compat`) are added after the ones from `Encore.addAliases(...)`, which prevents overwriting them using this method. It makes more sense to change that order so aliases from `Encore.addAliases(...)` are always added last (fixes #625). Commits ------- 29d1cb4 Allow to overwrite pre-defined aliases using addAliases()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pre-defined aliases (used by
vueandpreact-compat) are added after the ones fromEncore.addAliases(...), which prevents overwriting them using this method.It makes more sense to change that order so aliases from
Encore.addAliases(...)are always added last (fixes #625).