Skip to content

Conversation

@weaverryan
Copy link
Member

@weaverryan weaverryan commented Nov 9, 2018

Fixes #435 and fixes #434

@weaverryan weaverryan changed the title Appending the _tmp_shared contents via an earlier hook [WIP] Appending the _tmp_shared contents via an earlier hook Nov 9, 2018
@weaverryan weaverryan changed the title [WIP] Appending the _tmp_shared contents via an earlier hook Appending the _tmp_shared contents via an earlier hook Nov 9, 2018
This small, internal change was causing the final output code to be
*slightly* different.
@weaverryan weaverryan force-pushed the move-tmp_shared_entry-earlier branch from 1011b84 to 42ec9ef Compare November 11, 2018 18:30
@weaverryan weaverryan merged commit 42ec9ef into symfony:master Nov 16, 2018
weaverryan added a commit that referenced this pull request Nov 16, 2018
…erryan)

This PR was squashed before being merged into the master branch (closes #441).

Discussion
----------

Appending the _tmp_shared contents via an earlier hook

Fixes #435 and fixes #434

Commits
-------

42ec9ef Using a static, not random filename for the _tmp_shared entry
c2ba1d6 updating shared-entry-contact-plugin code for emit
fbf6121 removing non-existent method on this hook
5f9d2ee Appending the _tmp_shared contents via an earlier hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant