Added support for the handlebars-loader #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
requested changes
Apr 16, 2018
Collaborator
Lyrkan
left a comment
Lyrkan
left a comment
There was a problem hiding this comment.
Thank you @ogiammetta, that looks really good to me!
I think the only thing that needs to be changed is the way the options callback is handled... but that's only because #300 was merged after you created this PR :)
Author
|
I have done all the changes you asked. I also added a test without callback. |
Lyrkan
approved these changes
Apr 17, 2018
Member
|
Wow, great work Olivier! And congrats on your first GitHub PR. You're welcome here anytime ;) |
weaverryan
added a commit
that referenced
this pull request
Apr 21, 2018
This PR was merged into the master branch. Discussion ---------- Added support for the handlebars-loader First PR on GitHub, any feedback is appreciated! :) Commits ------- 3aafa2e Added support for the handlebars-loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR on GitHub, any feedback is appreciated! :)