Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

Conversation

@javiereguiluz
Copy link
Member

This fixes #172

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you find this behavior? In Composer itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it here: https://github.com/composer/composer/blob/69210d5bc130f8cc9f96f99582a041254d7b9833/src/Composer/Factory.php#L309 But to be sure I made an md5 of several composer.json files and they matched the values stored in composer.lock.

@stof
Copy link
Member

stof commented Jun 25, 2015

@javiereguiluz reimplementing the composer hashing here has a drawback though: the logic will become much more complex once composer improves its hashing by hashing only the relevant informations (which would require you to update a second hash for the new API).
But anyway, I guess we can live with this solution for now. Nobody is currently working on improving the hash computation, so it won't be there soon AFAICT. So 👍 from me

@javiereguiluz
Copy link
Member Author

@stof I agree with you. Let's merge this for now and if someday Composer changes the hashing algorithm, we'll match their implementation or drop this feature, whichever is easier for us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new project contains a mismatched composer.lock

3 participants