bug #278 Fix lowercase issues with unicode characters (Pierstoval, javiereguiluz)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Fix lowercase issues with unicode characters

@Pierstoval I tried your proposal in #197 but it didn't work for me. This new PR proposes to fix most of the errors for European languages. Sadly it won't work for Japanese, Chinese, Arabic, Hebrew, etc.

Commits
-------

19b6799 Missing EOL
74d991b Clean the package names using the same regexp as Composer
4773869 Finished this feature
e1de703 Try to fix #190 by fixing lowercase package name

Author: javiereguiluz

src/Symfony/Installer/NewCommand.php

@@ -378,13 +378,14 @@ protected function generateComposerProjectName()
      */
     private function fixComposerPackageName($name)
     {
-        return strtolower(
-            preg_replace(
-                array('/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'),
-                array('\\1-\\2', '\\1-\\2'),
-                strtr($name, '-', '.')
-            )
+        $name = str_replace(
+            ['à', 'á', 'â', 'ä', 'æ', 'ã', 'å', 'ā', 'é', 'è', 'ê', 'ë', 'ę', 'ė', 'ē', 'ī', 'į', 'í', 'ì', 'ï', 'î', 'ō', 'ø', 'œ', 'õ', 'ó', 'ò', 'ö', 'ô', 'ū', 'ú', 'ù', 'ü', 'û', 'ç', 'ć', 'č', 'ł', 'ñ', 'ń', 'ß', 'ś', 'š', 'ŵ', 'ŷ', 'ÿ', 'ź', 'ž', 'ż'],
+            ['a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'e', 'e', 'e', 'e', 'e', 'e', 'e', 'i', 'i', 'i', 'i', 'i', 'i', 'o', 'o', 'o', 'o', 'o', 'o', 'o', 'o', 'u', 'u', 'u', 'u', 'u', 'c', 'c', 'c', 'l', 'n', 'n', 's', 's', 's', 'w', 'y', 'y', 'z', 'z', 'z'],
+            $name
         );
+        $name = preg_replace('#[^A-Za-z0-9_./-]+#', '', $name);
+
+        return strtolower($name);
     }
 
     /**

tests/Symfony/Installer/Tests/NewCommandTest.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Symfony\Installer\Tests;
+
+use Symfony\Installer\NewCommand;
+
+class NewCommandTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @dataProvider getProjectNames
+     */
+    public function testFixComposerPackageName($originalName, $expectedName)
+    {
+        $command = new NewCommand();
+        $method = new \ReflectionMethod($command, 'fixComposerPackageName');
+        $method->setAccessible(true);
+
+        $fixedName = $method->invoke($command, $originalName);
+        $this->assertSame($expectedName, $fixedName);
+    }
+
+    public function getProjectNames()
+    {
+        return [
+            ['foo/bar', 'foo/bar'],
+            ['áèî/øū', 'aei/ou'],
+            ['çñß/łŵž', 'cns/lwz'],
+            ['foo#bar\foo?bar=foo!bar{foo]bar', 'foobarfoobarfoobarfoobar'],
+            ['FOO/bar', 'foo/bar'],
+        ];
+    }
+}