[HttpClient] Fix Process-based escaping in HttpClientDataCollector

nicolas-grekas · nicolas-grekas · commit aa7bebe6521f · 2024-10-30T22:35:56.000+01:00
diff --git a/DataCollector/HttpClientDataCollector.php b/DataCollector/HttpClientDataCollector.php
@@ -253,7 +253,7 @@ private function escapePayload(string $payload): string
         static $useProcess;
 
         if ($useProcess ??= function_exists('proc_open') && class_exists(Process::class)) {
-            return (new Process([$payload]))->getCommandLine();
+            return substr((new Process(['', $payload]))->getCommandLine(), 3);
         }
 
         if ('\\' === \DIRECTORY_SEPARATOR) {

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,7 @@ private function escapePayload(string $payload): string`
`253`	`253`	`static $useProcess;`
`254`	`254`
`255`	`255`	`if ($useProcess ??= function_exists('proc_open') && class_exists(Process::class)) {`
`256`		`- return (new Process([$payload]))->getCommandLine();`
	`256`	`+ return substr((new Process(['', $payload]))->getCommandLine(), 3);`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`if ('\\' === \DIRECTORY_SEPARATOR) {`