Add void return types

Author: wouterj

Application.php

@@ -105,11 +105,14 @@ public function __construct(string $name = 'UNKNOWN', string $version = 'UNKNOWN
     /**
      * @final
      */
-    public function setDispatcher(EventDispatcherInterface $dispatcher)
+    public function setDispatcher(EventDispatcherInterface $dispatcher): void
     {
         $this->dispatcher = $dispatcher;
     }
 
+    /**
+     * @return void
+     */
     public function setCommandLoader(CommandLoaderInterface $commandLoader)
     {
         $this->commandLoader = $commandLoader;
@@ -124,6 +127,9 @@ public function getSignalRegistry(): SignalRegistry
         return $this->signalRegistry;
     }
 
+    /**
+     * @return void
+     */
     public function setSignalsToDispatchEvent(int ...$signalsToDispatchEvent)
     {
         $this->signalsToDispatchEvent = $signalsToDispatchEvent;
@@ -317,10 +323,16 @@ public function doRun(InputInterface $input, OutputInterface $output)
         return $exitCode;
     }
 
+    /**
+     * @return void
+     */
     public function reset()
     {
     }
 
+    /**
+     * @return void
+     */
     public function setHelperSet(HelperSet $helperSet)
     {
         $this->helperSet = $helperSet;
@@ -334,6 +346,9 @@ public function getHelperSet(): HelperSet
         return $this->helperSet ??= $this->getDefaultHelperSet();
     }
 
+    /**
+     * @return void
+     */
     public function setDefinition(InputDefinition $definition)
     {
         $this->definition = $definition;
@@ -404,6 +419,8 @@ public function areExceptionsCaught(): bool
 
     /**
      * Sets whether to catch exceptions or not during commands execution.
+     *
+     * @return void
      */
     public function setCatchExceptions(bool $boolean)
     {
@@ -420,6 +437,8 @@ public function isAutoExitEnabled(): bool
 
     /**
      * Sets whether to automatically exit after a command execution or not.
+     *
+     * @return void
      */
     public function setAutoExit(bool $boolean)
     {
@@ -436,7 +455,9 @@ public function getName(): string
 
     /**
      * Sets the application name.
-     **/
+     *
+     * @return void
+     */
     public function setName(string $name)
     {
         $this->name = $name;
@@ -452,6 +473,8 @@ public function getVersion(): string
 
     /**
      * Sets the application version.
+     *
+     * @return void
      */
     public function setVersion(string $version)
     {
@@ -490,6 +513,8 @@ public function register(string $name): Command
      * If a Command is not enabled it will not be added.
      *
      * @param Command[] $commands An array of commands
+     *
+     * @return void
      */
     public function addCommands(array $commands)
     {
@@ -899,6 +924,8 @@ protected function doRenderThrowable(\Throwable $e, OutputInterface $output): vo
 
     /**
      * Configures the input and output instances based on the user arguments and options.
+     *
+     * @return void
      */
     protected function configureIO(InputInterface $input, OutputInterface $output)
     {
@@ -1250,7 +1277,7 @@ private function extractAllNamespaces(string $name): array
         return $namespaces;
     }
 
-    private function init()
+    private function init(): void
     {
         if ($this->initialized) {
             return;

Command/Command.php

@@ -141,12 +141,17 @@ public function __construct(string $name = null)
      * Ignores validation errors.
      *
      * This is mainly useful for the help command.
+     *
+     * @return void
      */
     public function ignoreValidationErrors()
     {
         $this->ignoreValidationErrors = true;
     }
 
+    /**
+     * @return void
+     */
     public function setApplication(Application $application = null)
     {
         if (1 > \func_num_args()) {
@@ -162,6 +167,9 @@ public function setApplication(Application $application = null)
         $this->fullDefinition = null;
     }
 
+    /**
+     * @return void
+     */
     public function setHelperSet(HelperSet $helperSet)
     {
         $this->helperSet = $helperSet;
@@ -198,6 +206,8 @@ public function isEnabled()
 
     /**
      * Configures the current command.
+     *
+     * @return void
      */
     protected function configure()
     {
@@ -228,6 +238,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
      * This method is executed before the InputDefinition is validated.
      * This means that this is the only place where the command can
      * interactively ask for values of missing required arguments.
+     *
+     * @return void
      */
     protected function interact(InputInterface $input, OutputInterface $output)
     {
@@ -242,6 +254,8 @@ protected function interact(InputInterface $input, OutputInterface $output)
      *
      * @see InputInterface::bind()
      * @see InputInterface::validate()
+     *
+     * @return void
      */
     protected function initialize(InputInterface $input, OutputInterface $output)
     {
@@ -378,7 +392,7 @@ public function setCode(callable $code): static
      *
      * @internal
      */
-    public function mergeApplicationDefinition(bool $mergeArgs = true)
+    public function mergeApplicationDefinition(bool $mergeArgs = true): void
     {
         if (null === $this->application) {
             return;
@@ -702,7 +716,7 @@ public function getHelper(string $name): mixed
      *
      * @throws InvalidArgumentException When the name is invalid
      */
-    private function validateName(string $name)
+    private function validateName(string $name): void
     {
         if (!preg_match('/^[^\:]++(\:[^\:]++)*$/', $name)) {
             throw new InvalidArgumentException(sprintf('Command name "%s" is invalid.', $name));

Command/CompleteCommand.php

@@ -74,7 +74,7 @@ protected function configure(): void
         ;
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output)
+    protected function initialize(InputInterface $input, OutputInterface $output): void
     {
         $this->isDebug = filter_var(getenv('SYMFONY_COMPLETION_DEBUG'), \FILTER_VALIDATE_BOOL);
     }

Command/DumpCompletionCommand.php

@@ -39,7 +39,7 @@ final class DumpCompletionCommand extends Command
 
     private array $supportedShells;
 
-    protected function configure()
+    protected function configure(): void
     {
         $fullCommand = $_SERVER['PHP_SELF'];
         $commandName = basename($fullCommand);

Command/HelpCommand.php

@@ -27,6 +27,9 @@ class HelpCommand extends Command
 {
     private Command $command;
 
+    /**
+     * @return void
+     */
     protected function configure()
     {
         $this->ignoreValidationErrors();
@@ -54,6 +57,9 @@ protected function configure()
         ;
     }
 
+    /**
+     * @return void
+     */
     public function setCommand(Command $command)
     {
         $this->command = $command;

Command/ListCommand.php

@@ -25,6 +25,9 @@
  */
 class ListCommand extends Command
 {
+    /**
+     * @return void
+     */
     protected function configure()
     {
         $this

DependencyInjection/AddConsoleCommandPass.php

@@ -29,6 +29,9 @@
  */
 class AddConsoleCommandPass implements CompilerPassInterface
 {
+    /**
+     * @return void
+     */
     public function process(ContainerBuilder $container)
     {
         $commandServices = $container->findTaggedServiceIds('console.command', true);

Descriptor/ApplicationDescription.php

@@ -79,7 +79,7 @@ public function getCommand(string $name): Command
         return $this->commands[$name] ?? $this->aliases[$name];
     }
 
-    private function inspectApplication()
+    private function inspectApplication(): void
     {
         $this->commands = [];
         $this->namespaces = [];

Descriptor/Descriptor.php

@@ -26,12 +26,9 @@
  */
 abstract class Descriptor implements DescriptorInterface
 {
-    /**
-     * @var OutputInterface
-     */
-    protected $output;
+    protected OutputInterface $output;
 
-    public function describe(OutputInterface $output, object $object, array $options = [])
+    public function describe(OutputInterface $output, object $object, array $options = []): void
     {
         $this->output = $output;
 
@@ -45,10 +42,7 @@ public function describe(OutputInterface $output, object $object, array $options
         };
     }
 
-    /**
-     * Writes content to output.
-     */
-    protected function write(string $content, bool $decorated = false)
+    protected function write(string $content, bool $decorated = false): void
     {
         $this->output->write($content, false, $decorated ? OutputInterface::OUTPUT_NORMAL : OutputInterface::OUTPUT_RAW);
     }

Descriptor/JsonDescriptor.php

@@ -26,30 +26,30 @@
  */
 class JsonDescriptor extends Descriptor
 {
-    protected function describeInputArgument(InputArgument $argument, array $options = [])
+    protected function describeInputArgument(InputArgument $argument, array $options = []): void
     {
         $this->writeData($this->getInputArgumentData($argument), $options);
     }
 
-    protected function describeInputOption(InputOption $option, array $options = [])
+    protected function describeInputOption(InputOption $option, array $options = []): void
     {
         $this->writeData($this->getInputOptionData($option), $options);
         if ($option->isNegatable()) {
             $this->writeData($this->getInputOptionData($option, true), $options);
         }
     }
 
-    protected function describeInputDefinition(InputDefinition $definition, array $options = [])
+    protected function describeInputDefinition(InputDefinition $definition, array $options = []): void
     {
         $this->writeData($this->getInputDefinitionData($definition), $options);
     }
 
-    protected function describeCommand(Command $command, array $options = [])
+    protected function describeCommand(Command $command, array $options = []): void
     {
         $this->writeData($this->getCommandData($command, $options['short'] ?? false), $options);
     }
 
-    protected function describeApplication(Application $application, array $options = [])
+    protected function describeApplication(Application $application, array $options = []): void
     {
         $describedNamespace = $options['namespace'] ?? null;
         $description = new ApplicationDescription($application, $describedNamespace, true);
@@ -81,7 +81,7 @@ protected function describeApplication(Application $application, array $options
     /**
      * Writes data as json.
      */
-    private function writeData(array $data, array $options)
+    private function writeData(array $data, array $options): void
     {
         $flags = $options['json_encoding'] ?? 0;