Test fix

Author: Nyholm

config/services.yaml

@@ -73,7 +73,7 @@ services:
 
     App\Api\Issue\IssueApi: '@App\Api\Issue\GithubIssueApi'
     App\Api\Label\LabelApi: '@App\Api\Label\GithubLabelApi'
-    App\Api\Milestone\MilestonesApi: '@App\Api\Issue\GithubIssueApi'
+    App\Api\Milestone\MilestonesApi: '@App\Api\Milestone\GithubMilestonesApi'
     App\Api\Status\StatusApi: '@App\Api\Status\GitHubStatusApi'
 
     App\Service\RepositoryProvider:

config/services_test.yaml

@@ -5,5 +5,5 @@ services:
 
     App\Api\Issue\IssueApi: '@App\Api\Issue\NullIssueApi'
     App\Api\Label\LabelApi: '@App\Api\Label\StaticLabelApi'
-    App\Api\Milestone\MilestonesApi: '@App\Api\Issue\NullIssueApi'
+    App\Api\Milestone\MilestonesApi: '@App\Api\Milestone\StaticMilestoneApi'
     App\Api\Status\StatusApi: '@App\Api\Status\NullStatusApi'

src/Api/Milestone/StaticMilestoneApi.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Api\Milestone;
+
+use App\Model\Repository;
+
+/**
+ * Dont fetch data from external source.
+ *
+ * @author Tobias Nyholm <[email protected]>
+ */
+class StaticMilestoneApi extends NullMilestoneApi
+{
+    public function exists(Repository $repository, string $milestoneName): bool
+    {
+        return in_array($milestoneName, ['3.4', '4.4', '5.1', '5.x']);
+    }
+}

tests/Controller/WebhookControllerTest.php

@@ -2,8 +2,8 @@
 
 namespace App\Tests\Controller;
 
-use App\Issues\StatusApi;
-use App\Repository\Provider\RepositoryProviderInterface;
+use App\Api\Status\StatusApi;
+use App\Service\RepositoryProvider;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class WebhookControllerTest extends WebTestCase
@@ -17,7 +17,7 @@ public function setup()
         }
 
         $this->client = $this->createClient();
-        $repository = self::$container->get(RepositoryProviderInterface::class);
+        $repository = self::$container->get(RepositoryProvider::class);
         $statusApi = self::$container->get(StatusApi::class);
 
         // the labels need to be off this issue for one test to pass