Skip to content

Commit 37bf884

Browse files
committed
Made PHPCR initializer independent from Sonata-related setting, creating all defined route_basepaths
1 parent e3ad1c0 commit 37bf884

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

DependencyInjection/CmfRoutingExtension.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ private function loadPhpcrProvider($config, XmlFileLoader $loader, ContainerBuil
223223
if ($config['use_sonata_admin']) {
224224
$this->loadSonataPhpcrAdmin($config, $loader, $container);
225225
}
226+
227+
if ($config['enable_initializer']) {
228+
$loader->load('initializer-phpcr.xml');
229+
}
226230
}
227231

228232
private function loadSonataPhpcrAdmin($config, XmlFileLoader $loader, ContainerBuilder $container)
@@ -236,10 +240,6 @@ private function loadSonataPhpcrAdmin($config, XmlFileLoader $loader, ContainerB
236240

237241
$basePath = $config['admin_basepath'] ?: reset($config['route_basepaths']);
238242
$container->setParameter('cmf_routing.dynamic.persistence.phpcr.admin_basepath', $basePath);
239-
240-
if ($config['enable_initializer']) {
241-
$loader->load('initializer-phpcr.xml');
242-
}
243243
}
244244

245245
private function loadOrmProvider($config, XmlFileLoader $loader, ContainerBuilder $container, $matchImplicitLocale)

Resources/config/initializer-phpcr.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<service id="cmf_routing.initializer" class="Doctrine\Bundle\PHPCRBundle\Initializer\GenericInitializer">
1010
<argument>CmfRoutingBundle</argument>
1111
<argument type="collection">
12-
<argument>%cmf_routing.dynamic.persistence.phpcr.admin_basepath%</argument>
12+
<argument>%cmf_routing.dynamic.persistence.phpcr.route_basepath%</argument>
1313
</argument>
1414
<tag name="doctrine_phpcr.initializer"/>
1515
</service>

Tests/Unit/DependencyInjection/CmfRoutingExtensionTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,6 @@ public function testInitializerDisabled()
300300
'kernel.bundles',
301301
array(
302302
'CmfRoutingBundle' => true,
303-
'SonataDoctrinePHPCRAdminBundle' => true,
304303
)
305304
);
306305

@@ -310,7 +309,6 @@ public function testInitializerDisabled()
310309
'persistence' => array(
311310
'phpcr' => array(
312311
'enabled' => true,
313-
'use_sonata_admin' => true,
314312
'enable_initializer' => false,
315313
),
316314
),
@@ -320,7 +318,7 @@ public function testInitializerDisabled()
320318
$this->assertFalse($this->container->has('cmf_routing.initializer'));
321319
}
322320

323-
public function testInitializerDisabledWithoutSonata()
321+
public function testInitializerEnabledEvenWithoutSonata()
324322
{
325323
$this->load(array(
326324
'dynamic' => array(
@@ -329,11 +327,12 @@ public function testInitializerDisabledWithoutSonata()
329327
'phpcr' => array(
330328
'enabled' => true,
331329
'use_sonata_admin' => false,
330+
'enable_initializer' => true,
332331
),
333332
),
334333
),
335334
));
336335

337-
$this->assertFalse($this->container->has('cmf_routing.initializer'));
336+
$this->assertTrue($this->container->has('cmf_routing.initializer'));
338337
}
339338
}

0 commit comments

Comments
 (0)