Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GridFieldComponents work with arbitrary ViewableData where practical (gridfieldextensions edition) #376

Open
4 tasks
GuySartorelli opened this issue Nov 27, 2023 · 0 comments

Comments

@GuySartorelli
Copy link
Collaborator

GuySartorelli commented Nov 27, 2023

silverstripe/silverstripe-framework#10771 made it easier to use the core gridfield components with arbitrary data.

A similar review should be done with components in this module, so that it's easier to use them with non-DataObject data and so that it's clearer when that's just not an option.

Acceptance Criteria

  • Where practical, all GridFieldComponent classes work with arbitrary ViewableData
  • If some methods need to be implemented for a component to work, a clear exception is thrown indicating what changes the developer needs to make. See Make GridField components work with ViewableData where possible silverstripe/silverstripe-framework#11049 for examples
  • Tests are put in place to avoid regressions
  • For any component where it is not practical to use it with ViewableData (if any), this is clearly documented in a way that developers can identify from within their IDE.
@GuySartorelli GuySartorelli changed the title Make GridFieldComponents work with arbitrary ViewableData where practical Make GridFieldComponents work with arbitrary ViewableData where practical (gridfieldextensions edition) Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant