From a027937aee1db0f5df43dab46d89802b9da56ed2 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 14:30:29 +0000 Subject: [PATCH 01/36] workflow run testing --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3bc37f10 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 35b81651b0cd901510bd53702993a52d7c543e22 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 14:42:55 +0000 Subject: [PATCH 02/36] default branch only workaround test --- .github/workflows/broken-link-checker-inline.yml | 3 +++ consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 438a9596..84146dfd 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -1,6 +1,7 @@ name: Broken Link Check on: + workflow_dispatch: workflow_run: workflows: ["Helm Linter"] types: @@ -12,7 +13,9 @@ jobs: steps: - uses: actions/checkout@v3 with: + ref: ${{ github.event.workflow_run.head_branch }} fetch-depth: 0 + - run: git branch # Find the PR associated with this push, if there is one. - uses: jwalton/gh-find-current-pr@v1 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3bc37f10..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 646d9741eed318a4a02272c2237753d7ee28b5af Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 15:13:03 +0000 Subject: [PATCH 03/36] where theres a will, theres a way --- .../workflows/broken-link-checker-inline.yml | 17 +++++++++++------ consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 84146dfd..643e26d1 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -2,20 +2,25 @@ name: Broken Link Check on: workflow_dispatch: - workflow_run: - workflows: ["Helm Linter"] - types: - - completed + push: jobs: linkChecker: + name: Link Checker runs-on: ubuntu-latest steps: + + - name: Wait for Helm Linter workflow to succeed + uses: lewagon/wait-on-check-action@v1.3.1 + with: + ref: ${{ github.ref }} + check-name: 'Helm Linter' + repo-token: ${{ secrets.GITHUB_TOKEN }} + wait-interval: 10 + - uses: actions/checkout@v3 with: - ref: ${{ github.event.workflow_run.head_branch }} fetch-depth: 0 - - run: git branch # Find the PR associated with this push, if there is one. - uses: jwalton/gh-find-current-pr@v1 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3e78fdb9 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introoo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From a0157f204edf334e1bf48bb0d61f1f3d6af606c8 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 15:16:28 +0000 Subject: [PATCH 04/36] order steps --- .github/workflows/broken-link-checker-inline.yml | 16 ++++++++-------- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 643e26d1..1ad4ed5f 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -10,14 +10,6 @@ jobs: runs-on: ubuntu-latest steps: - - name: Wait for Helm Linter workflow to succeed - uses: lewagon/wait-on-check-action@v1.3.1 - with: - ref: ${{ github.ref }} - check-name: 'Helm Linter' - repo-token: ${{ secrets.GITHUB_TOKEN }} - wait-interval: 10 - - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -34,6 +26,14 @@ jobs: env: PR: ${{ steps.findPr.outputs.pr }} + - name: Wait for Helm Linter workflow to succeed + uses: lewagon/wait-on-check-action@v1.3.1 + with: + ref: ${{ github.ref }} + check-name: 'Helm Linter' + repo-token: ${{ secrets.GITHUB_TOKEN }} + wait-interval: 10 + - name: Get changed files id: changed-files uses: tj-actions/changed-files@v35 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3e78fdb9..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introoo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From de4381be3c3f5e78862c5e71d6eb32fac8479101 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 15:23:17 +0000 Subject: [PATCH 05/36] testing --- .../workflows/broken-link-checker-inline.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 1ad4ed5f..f717b8c1 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -10,6 +10,15 @@ jobs: runs-on: ubuntu-latest steps: + - name: Wait for Helm Linter workflow to succeed + uses: lewagon/wait-on-check-action@v1.3.1 + with: + #ref: ${{ github.ref }} + ref: ${{ github.event.pull_request.head.sha }} + check-name: 'Helm Linter' + repo-token: ${{ secrets.GITHUB_TOKEN }} + wait-interval: 10 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -26,14 +35,6 @@ jobs: env: PR: ${{ steps.findPr.outputs.pr }} - - name: Wait for Helm Linter workflow to succeed - uses: lewagon/wait-on-check-action@v1.3.1 - with: - ref: ${{ github.ref }} - check-name: 'Helm Linter' - repo-token: ${{ secrets.GITHUB_TOKEN }} - wait-interval: 10 - - name: Get changed files id: changed-files uses: tj-actions/changed-files@v35 From b54d9db1d9567dc6b3dd3da9d3ae33622efc3a6c Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 15:31:36 +0000 Subject: [PATCH 06/36] testing again --- .github/workflows/broken-link-checker-inline.yml | 6 +++--- .github/workflows/helm-linter-inline.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index f717b8c1..c7b14051 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -13,9 +13,9 @@ jobs: - name: Wait for Helm Linter workflow to succeed uses: lewagon/wait-on-check-action@v1.3.1 with: - #ref: ${{ github.ref }} - ref: ${{ github.event.pull_request.head.sha }} - check-name: 'Helm Linter' + ref: ${{ github.ref }} + #ref: ${{ github.event.pull_request.head.sha }} + check-name: helmLinter repo-token: ${{ secrets.GITHUB_TOKEN }} wait-interval: 10 diff --git a/.github/workflows/helm-linter-inline.yml b/.github/workflows/helm-linter-inline.yml index 1215f7c6..58adad63 100644 --- a/.github/workflows/helm-linter-inline.yml +++ b/.github/workflows/helm-linter-inline.yml @@ -5,7 +5,7 @@ on: push: jobs: - linkChecker: + helmLinter: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 From 992abd64b1b7f3ba0305fc1b164e428b43961075 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 17:07:17 +0000 Subject: [PATCH 07/36] test with doc changes --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3e78fdb9 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introoo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 3f9e5aeca82294d56f99ed20b66876a6b2b286e4 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 17:25:47 +0000 Subject: [PATCH 08/36] exit code tester --- .github/workflows/broken-link-checker-inline.yml | 13 ++++++++++--- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index c7b14051..cc60acad 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -55,8 +55,8 @@ jobs: uses: lycheeverse/lychee-action@v1.6.1 with: args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://tutorials-git-${{ steps.findPr.outputs.pr }}-hashicorp.vercel.app/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --max-concurrency=24 --no-progress --verbose - # Fail GitHub action when broken links are found? - fail: true + # Fail GitHub action at this step when broken links are found? + fail: false env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} @@ -65,4 +65,11 @@ jobs: uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report - content-filepath: ./lychee/out.md \ No newline at end of file + content-filepath: ./lychee/out.md + + - name: lychee exit code check + if: env.lychee_exit_code != 0 + uses: actions/github-script@v3 + with: + script: | + core.setFailed('lychee failed with exit code ${{env.lychee_exit_code}}') \ No newline at end of file diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3e78fdb9..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introoo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 776b9dde65155c2439d0b02b82945bc520cb033b Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 17:36:11 +0000 Subject: [PATCH 09/36] test --- .github/workflows/broken-link-checker-inline.yml | 3 +++ consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index cc60acad..c1eddeaf 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -4,6 +4,9 @@ on: workflow_dispatch: push: +permissions: + pull-requests: write + jobs: linkChecker: name: Link Checker diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3bc37f10 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 9761c5a3e6edb69c2cbc76d0ecf19dd1af8e4f04 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 17:45:17 +0000 Subject: [PATCH 10/36] testeroni --- .github/workflows/broken-link-checker-inline.yml | 1 + consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index c1eddeaf..fbf3a078 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -68,6 +68,7 @@ jobs: uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report + number: ${{ steps.findPr.outputs.pr }} content-filepath: ./lychee/out.md - name: lychee exit code check diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3bc37f10..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 4e7810cdd6ab4932afed4c33ff697a778dacdf5e Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 17:47:00 +0000 Subject: [PATCH 11/36] u test me --- .github/workflows/broken-link-checker-inline.yml | 2 +- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index fbf3a078..1a0d2f63 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -69,7 +69,7 @@ jobs: with: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} - content-filepath: ./lychee/out.md + path: ./lychee/out.md - name: lychee exit code check if: env.lychee_exit_code != 0 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3bc37f10 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 684ebc70373b75183dcd9e1559ebeeef701b7352 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Fri, 21 Apr 2023 17:48:50 +0000 Subject: [PATCH 12/36] PR comment testing --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3bc37f10..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 56109e4692f346cdaaaff81123f3e677dc2d26eb Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:12:09 +0000 Subject: [PATCH 13/36] testing --- .../workflows/broken-link-checker-inline.yml | 20 +++++++++++++++++-- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 1a0d2f63..706de650 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -6,6 +6,8 @@ on: permissions: pull-requests: write + checks: read + contents: read jobs: linkChecker: @@ -57,20 +59,34 @@ jobs: id: lychee uses: lycheeverse/lychee-action@v1.6.1 with: - args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://tutorials-git-${{ steps.findPr.outputs.pr }}-hashicorp.vercel.app/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --max-concurrency=24 --no-progress --verbose + args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://developer.hashicorp.com/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --accept 403,200,429 --timeout=60 --max-concurrency=24 --no-progress --verbose # Fail GitHub action at this step when broken links are found? fail: false env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + - name: Troubleshoot Append text to beginning of Lychee output file + run: | + ls + +# - name: Append text to beginning of Lychee output file +# # Append lychee output file under any lychee condition +# if: env.lychee_exit_code != 3 +# run: | +# sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md + + # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output - if: env.lychee_exit_code != 0 + if: env.lychee_exit_code != 3 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md + # Subsequent runs will recreate PR comment with latest results + recreate: true + # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check if: env.lychee_exit_code != 0 uses: actions/github-script@v3 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..0cf5d210 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 4158e99fdf8493b2100132117c751e8082ac72b0 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:14:36 +0000 Subject: [PATCH 14/36] test again --- .github/workflows/broken-link-checker-inline.yml | 4 ++-- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 706de650..a549300e 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -59,7 +59,7 @@ jobs: id: lychee uses: lycheeverse/lychee-action@v1.6.1 with: - args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://developer.hashicorp.com/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --accept 403,200,429 --timeout=60 --max-concurrency=24 --no-progress --verbose + args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://developer.hashicorp.com/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --accept 403,200,429 --max-concurrency=24 --no-progress --verbose # Fail GitHub action at this step when broken links are found? fail: false env: @@ -84,7 +84,7 @@ jobs: number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md # Subsequent runs will recreate PR comment with latest results - recreate: true + #recreate: true # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 0cf5d210..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From ff34e2b7cfb53d4491b0b570c6c71a938eac7a7b Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:17:56 +0000 Subject: [PATCH 15/36] testing --- .../workflows/broken-link-checker-inline.yml | 18 ++---------------- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index a549300e..73aef2df 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -6,8 +6,6 @@ on: permissions: pull-requests: write - checks: read - contents: read jobs: linkChecker: @@ -59,32 +57,20 @@ jobs: id: lychee uses: lycheeverse/lychee-action@v1.6.1 with: - args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://developer.hashicorp.com/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --accept 403,200,429 --max-concurrency=24 --no-progress --verbose + args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://developer.hashicorp.com/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --max-concurrency=24 --no-progress --verbose # Fail GitHub action at this step when broken links are found? fail: false env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file - run: | - ls - -# - name: Append text to beginning of Lychee output file -# # Append lychee output file under any lychee condition -# if: env.lychee_exit_code != 3 -# run: | -# sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md - # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output - if: env.lychee_exit_code != 3 + if: env.lychee_exit_code != 0 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md - # Subsequent runs will recreate PR comment with latest results - #recreate: true # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..0cf5d210 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From ed824f6df761cca6d10248a2882b48092b183cbd Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:19:34 +0000 Subject: [PATCH 16/36] testing again --- .github/workflows/broken-link-checker-inline.yml | 2 ++ consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 73aef2df..503704f0 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -6,6 +6,8 @@ on: permissions: pull-requests: write + checks: read + contents: read jobs: linkChecker: diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 0cf5d210..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From c000bd20b622104381af7e358c8fb2ebe2f1bb95 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:21:33 +0000 Subject: [PATCH 17/36] incremental testing --- .github/workflows/broken-link-checker-inline.yml | 10 ++++++++++ consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 503704f0..0756227b 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -65,6 +65,16 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + - name: Troubleshoot Append text to beginning of Lychee output file + run: | + ls + +# - name: Append text to beginning of Lychee output file +# # Append lychee output file under any lychee condition +# if: env.lychee_exit_code != 3 +# run: | +# sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md + # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output if: env.lychee_exit_code != 0 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..0cf5d210 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 131971a2fffce3423132fe585df3140d3f74a613 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:25:32 +0000 Subject: [PATCH 18/36] more incremental testing --- .github/workflows/broken-link-checker-inline.yml | 1 + consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 0756227b..0b88a1e7 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -83,6 +83,7 @@ jobs: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md + recreate: true # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 0cf5d210..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From d977ada49093ab0614ae10719fc9a29e866fe820 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:29:24 +0000 Subject: [PATCH 19/36] ink ra men tal --- .github/workflows/broken-link-checker-inline.yml | 3 ++- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 0b88a1e7..6a2d670f 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -67,6 +67,7 @@ jobs: - name: Troubleshoot Append text to beginning of Lychee output file run: | + pwd ls # - name: Append text to beginning of Lychee output file @@ -77,7 +78,7 @@ jobs: # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output - if: env.lychee_exit_code != 0 + if: env.lychee_exit_code != 3 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..0cf5d210 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From a8ee86f8d07c4cc54d9c864975f8b1bec29e47f9 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:32:21 +0000 Subject: [PATCH 20/36] either recreate or exit code --- .github/workflows/broken-link-checker-inline.yml | 2 +- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 6a2d670f..d613b988 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -78,7 +78,7 @@ jobs: # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output - if: env.lychee_exit_code != 3 + #if: env.lychee_exit_code != 0 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 0cf5d210..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From e772595b304c3462a74efddb043d2ed5ccd614b4 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:33:49 +0000 Subject: [PATCH 21/36] problems with recreate --- .github/workflows/broken-link-checker-inline.yml | 2 +- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index d613b988..4c350ad6 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -84,7 +84,7 @@ jobs: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md - recreate: true + #recreate: true # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..0cf5d210 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From fc682effff0783d368182b3c41abe8619138fe13 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:36:38 +0000 Subject: [PATCH 22/36] if clauses --- .../workflows/broken-link-checker-inline.yml | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 4c350ad6..c99bd0ed 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -66,6 +66,13 @@ jobs: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - name: Troubleshoot Append text to beginning of Lychee output file + if: env.lychee_exit_code != 0 + run: | + pwd + ls + + - name: Troubleshoot Append text to beginning of Lychee output file + if: env.lychee_exit_code = 0 run: | pwd ls @@ -77,14 +84,23 @@ jobs: # sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - - name: Comment on PR with lychee output - #if: env.lychee_exit_code != 0 + - name: Comment on PR with lychee output (failure condition) + if: env.lychee_exit_code != 0 + uses: marocchino/sticky-pull-request-comment@v2 + with: + header: Link Checker Report + number: ${{ steps.findPr.outputs.pr }} + path: ./lychee/out.md + recreate: true + + - name: Comment on PR with lychee output (success condition) + if: env.lychee_exit_code = 0 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md - #recreate: true + recreate: true # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check From a5e75b2b7a017b39a1e8d7f21678420325d2eb0c Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:37:36 +0000 Subject: [PATCH 23/36] tshoot --- .github/workflows/broken-link-checker-inline.yml | 4 ++-- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index c99bd0ed..f16c9b41 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -65,13 +65,13 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file + - name: Troubleshoot Append text to beginning of Lychee output file (failure) if: env.lychee_exit_code != 0 run: | pwd ls - - name: Troubleshoot Append text to beginning of Lychee output file + - name: Troubleshoot Append text to beginning of Lychee output file (success) if: env.lychee_exit_code = 0 run: | pwd diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 0cf5d210..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 0f52b3b401d6641aad579eca34847abbd2ea559c Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:39:12 +0000 Subject: [PATCH 24/36] these machines man --- .../workflows/broken-link-checker-inline.yml | 25 +++++++------------ consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 10 insertions(+), 17 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index f16c9b41..488fab8e 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -65,16 +65,9 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file (failure) - if: env.lychee_exit_code != 0 - run: | - pwd - ls - - - name: Troubleshoot Append text to beginning of Lychee output file (success) + - name: Troubleshoot Append text to beginning of Lychee output file if: env.lychee_exit_code = 0 run: | - pwd ls # - name: Append text to beginning of Lychee output file @@ -84,14 +77,14 @@ jobs: # sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - - name: Comment on PR with lychee output (failure condition) - if: env.lychee_exit_code != 0 - uses: marocchino/sticky-pull-request-comment@v2 - with: - header: Link Checker Report - number: ${{ steps.findPr.outputs.pr }} - path: ./lychee/out.md - recreate: true +# - name: Comment on PR with lychee output (failure condition) +# if: env.lychee_exit_code != 0 +# uses: marocchino/sticky-pull-request-comment@v2 +# with: +# header: Link Checker Report +# number: ${{ steps.findPr.outputs.pr }} +# path: ./lychee/out.md +# recreate: true - name: Comment on PR with lychee output (success condition) if: env.lychee_exit_code = 0 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..0cf5d210 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 53026481e943f007aadd066a6759ed14e8106822 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:41:43 +0000 Subject: [PATCH 25/36] test --- .../workflows/broken-link-checker-inline.yml | 22 +++++-------------- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 488fab8e..3ff2ea96 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -65,10 +65,9 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file - if: env.lychee_exit_code = 0 - run: | - ls +# - name: Troubleshoot Append text to beginning of Lychee output file +# run: | +# ls # - name: Append text to beginning of Lychee output file # # Append lychee output file under any lychee condition @@ -77,23 +76,14 @@ jobs: # sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md # Comment on PR with lychee output; subsequent runs will modify existing content with latest results -# - name: Comment on PR with lychee output (failure condition) -# if: env.lychee_exit_code != 0 -# uses: marocchino/sticky-pull-request-comment@v2 -# with: -# header: Link Checker Report -# number: ${{ steps.findPr.outputs.pr }} -# path: ./lychee/out.md -# recreate: true - - - name: Comment on PR with lychee output (success condition) - if: env.lychee_exit_code = 0 + - name: Comment on PR with lychee output + if: env.lychee_exit_code != 1 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report number: ${{ steps.findPr.outputs.pr }} path: ./lychee/out.md - recreate: true + recreate: true # Fail github action if lychee exit code is anything other than the success code (0) - name: lychee exit code check diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 0cf5d210..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 00c1f6477d2a0a6b94373d5476f130978be0a927 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:43:31 +0000 Subject: [PATCH 26/36] testt --- .github/workflows/broken-link-checker-inline.yml | 2 +- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 3ff2ea96..22b03d81 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -77,7 +77,7 @@ jobs: # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output - if: env.lychee_exit_code != 1 + if: env.lychee_exit_code != 0 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3e78fdb9 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introoo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From d45e8c4c56166c8b1fabf39efe87dd0a9b1c95fd Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:48:19 +0000 Subject: [PATCH 27/36] exit code testing --- .github/workflows/broken-link-checker-inline.yml | 8 +++++--- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 22b03d81..a43e1175 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -60,14 +60,16 @@ jobs: uses: lycheeverse/lychee-action@v1.6.1 with: args: ${{ steps.changed-files.outputs.all_changed_files }} --base https://developer.hashicorp.com/ --exclude-all-private --exclude '\.(svg|gif|jpg|png)' --exclude 'manage\.auth0\.com' --max-concurrency=24 --no-progress --verbose + jobSummary: true # Fail GitHub action at this step when broken links are found? fail: false env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} -# - name: Troubleshoot Append text to beginning of Lychee output file -# run: | -# ls + - name: Troubleshoot Append text to beginning of Lychee output file + if: env.lychee_exit_code != 0 + run: | + ls # - name: Append text to beginning of Lychee output file # # Append lychee output file under any lychee condition diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3e78fdb9..8307820f 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introoo) page to learn more. +out the [What is Consul?](/consul/docs/introooo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 866b700b15d755646f8e3ff9812248fe7e94b9e1 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:52:52 +0000 Subject: [PATCH 28/36] double test --- .github/workflows/broken-link-checker-inline.yml | 9 ++++++++- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index a43e1175..a22d5cb4 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -66,10 +66,17 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file + - name: Troubleshoot Append text to beginning of Lychee output file (success) if: env.lychee_exit_code != 0 run: | ls + cat lychee/out.md + + - name: Troubleshoot Append text to beginning of Lychee output file (failure) + if: env.lychee_exit_code = 0 + run: | + ls + cat lychee/out.md # - name: Append text to beginning of Lychee output file # # Append lychee output file under any lychee condition diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 8307820f..3e78fdb9 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introooo) page to learn more. +out the [What is Consul?](/consul/docs/introoo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 8a88907091515c39c8b11ad62ec5b5eba00118e5 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:53:29 +0000 Subject: [PATCH 29/36] testing --- .github/workflows/broken-link-checker-inline.yml | 8 +------- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index a22d5cb4..65ec87bd 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -66,18 +66,12 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file (success) + - name: Troubleshoot Append text to beginning of Lychee output file if: env.lychee_exit_code != 0 run: | ls cat lychee/out.md - - name: Troubleshoot Append text to beginning of Lychee output file (failure) - if: env.lychee_exit_code = 0 - run: | - ls - cat lychee/out.md - # - name: Append text to beginning of Lychee output file # # Append lychee output file under any lychee condition # if: env.lychee_exit_code != 3 diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3e78fdb9..3bc37f10 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introoo) page to learn more. +out the [What is Consul?](/consul/docs/introo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From a6231e915549eb51b4e198d9e3a2ad130da6c1a3 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:56:44 +0000 Subject: [PATCH 30/36] do you need if statements for failure code --- .github/workflows/broken-link-checker-inline.yml | 4 ++-- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 65ec87bd..a3696e3e 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -67,7 +67,7 @@ jobs: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - name: Troubleshoot Append text to beginning of Lychee output file - if: env.lychee_exit_code != 0 + #if: env.lychee_exit_code != 0 run: | ls cat lychee/out.md @@ -80,7 +80,7 @@ jobs: # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - name: Comment on PR with lychee output - if: env.lychee_exit_code != 0 + #if: env.lychee_exit_code != 0 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3bc37f10..3e78fdb9 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introo) page to learn more. +out the [What is Consul?](/consul/docs/introoo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 797158469d40aa312c29cd80776b7ffc19307200 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 02:58:28 +0000 Subject: [PATCH 31/36] test working scenario --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3e78fdb9..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introoo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 8acbdbc42fcbadee1c5348e690e9f7787a32c654 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 03:04:59 +0000 Subject: [PATCH 32/36] test big test --- .../workflows/broken-link-checker-inline.yml | 24 +++++++++---------- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index a3696e3e..7c262165 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -66,21 +66,21 @@ jobs: env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - - name: Troubleshoot Append text to beginning of Lychee output file - #if: env.lychee_exit_code != 0 - run: | - ls - cat lychee/out.md - -# - name: Append text to beginning of Lychee output file -# # Append lychee output file under any lychee condition -# if: env.lychee_exit_code != 3 +# - name: Troubleshoot Append text to beginning of Lychee output file +# if: env.lychee_exit_code != 0 # run: | -# sed -i '1s/^/The GitHub action "Broken Link Check" has successfully completed on all content within the scope of this PR.\n/' ./lychee/out.md +# ls +# cat lychee/out.md + + - name: Append text to beginning of Lychee output file if broken links found + # Append lychee output file under any lychee condition + if: env.lychee_exit_code != 0 + run: | + sed -i '1s/^/The GitHub action "Broken Link Check" has completed running on all content within the scope of this PR.\n/' ./lychee/out.md # Comment on PR with lychee output; subsequent runs will modify existing content with latest results - - name: Comment on PR with lychee output - #if: env.lychee_exit_code != 0 + - name: Comment on PR with lychee output if broken links found + if: env.lychee_exit_code != 0 uses: marocchino/sticky-pull-request-comment@v2 with: header: Link Checker Report diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3bc37f10 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From 180dca95b4b01e47119dec84cd85a39d5cdc3bee Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 03:07:32 +0000 Subject: [PATCH 33/36] what happens to the pr comment when all links work --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3bc37f10..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From c5c5da551ef45eba63ef45984f8b86a759789bfc Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 03:13:54 +0000 Subject: [PATCH 34/36] big testing --- .github/workflows/broken-link-checker-inline.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/broken-link-checker-inline.yml b/.github/workflows/broken-link-checker-inline.yml index 7c262165..53f64dae 100644 --- a/.github/workflows/broken-link-checker-inline.yml +++ b/.github/workflows/broken-link-checker-inline.yml @@ -94,4 +94,12 @@ jobs: uses: actions/github-script@v3 with: script: | - core.setFailed('lychee failed with exit code ${{env.lychee_exit_code}}') \ No newline at end of file + core.setFailed('lychee failed with exit code ${{env.lychee_exit_code}}') + + # If all previous Github actions run (indicating success), this one will run and clean up PR comments + - name: Clean up PR comments if all previous steps succeed + uses: marocchino/sticky-pull-request-comment@v2 + with: + header: Link Checker Report + number: ${{ steps.findPr.outputs.pr }} + delete: true From a784c327b6a7ec5240f3cde5c963b2e7cf97971f Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 03:15:07 +0000 Subject: [PATCH 35/36] test failure scenario --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index ee3efbd4..3bc37f10 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/intro) page to learn more. +out the [What is Consul?](/consul/docs/introo) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI. From f99bbcb4eebc24fd67b0e5f98a500f786a8f4462 Mon Sep 17 00:00:00 2001 From: symbiontik Date: Wed, 26 Apr 2023 03:16:47 +0000 Subject: [PATCH 36/36] success scenario test --- consul/tutorials/kubernetes-gs-deploy.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consul/tutorials/kubernetes-gs-deploy.mdx b/consul/tutorials/kubernetes-gs-deploy.mdx index 3bc37f10..ee3efbd4 100644 --- a/consul/tutorials/kubernetes-gs-deploy.mdx +++ b/consul/tutorials/kubernetes-gs-deploy.mdx @@ -13,7 +13,7 @@ default_collection_context: consul/get-started-kubernetes Consul is a service networking solution that enables teams to manage secure network connectivity between services and across on-prem and multi-cloud environments and runtimes. Consul offers service discovery, service mesh, traffic management, and automated updates to network infrastructure devices. -out the [What is Consul?](/consul/docs/introo) page to learn more. +out the [What is Consul?](/consul/docs/intro) page to learn more. In this tutorial, you will deploy a Consul datacenter onto a Kubernetes cluster. After deploying Consul, you will interact with Consul using the UI and CLI.