Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use ripgrep/rg search symbol in project #16243

Closed
ccruquan opened this issue Jan 9, 2024 · 3 comments
Closed

Can't use ripgrep/rg search symbol in project #16243

ccruquan opened this issue Jan 9, 2024 · 3 comments

Comments

@ccruquan
Copy link
Contributor

ccruquan commented Jan 9, 2024

Description :octocat:

Can't use ripgrep/rg search symbol in project

Reproduction guide 🪲

  • Start Emacs
  • Open a project
  • Use rg search symbol in project "SPC s r p"
  • Type a word

Observed behaviour: 👀 💔
A message says rg: invalid CLI arguments: unexpected argument for option '--ignore': ".#*"

Expected behaviour: ❤️ 😄
Use ripgrep/rg search symbol in project

System Info 💻

  • OS: gnu/linux
  • Emacs: 29.1
  • Spacemacs: 0.999.0
  • Spacemacs branch: develop (rev. 3d84b01)
  • Graphic display: t
  • Running in daemon: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(windows-scripts auto-completion
                 lsp
                 git
                 (git :variables git-enable-magit-delta-plugin t git-enable-magit-delta-plugin t git-enable-magit-gitflow-plugin t)
                 helm
                 emacs-lisp
                 go
                 (go :variables go-backend 'lsp go-tab-width 4 go-format-before-save t godoc-at-point-function 'godoc-gogetdoc gofmt-command "goimports")
                 python
                 (python :variables python-backend 'lsp python-lsp-server 'pyright python-formatter 'black python-format-on-save t python-save-before-test t)
                 evil-better-jumper
                 )
  • System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Backtrace 🐾

<<BACKTRACE IF RELEVANT>>
@ccruquan
Copy link
Contributor Author

ccruquan commented Jan 9, 2024

I check the key binding 'SPC s r p' and find the function spacemacs/helm-project-do-rg.

(defun spacemacs/helm-files-do-rg (&optional dir)

Then I read the code of helm-ag.

helm-ag use '--ignore' option for ignore files:
https://github.com/emacsorphanage/helm-ag/blob/501af5cc7d9e9ae4473d84ba1ffb047ad8ef7fae/helm-ag.el#L189

Then I find the option '--ignore' is not used for ignore files in ripgrep doc.
https://github.com/BurntSushi/ripgrep/blob/648a65f1976cc3b7eb66425024649d71d5befe1e/doc/rg.1.txt.tpl#L90C38-L90C38

ripgrep use '--iglob'/'--glob' option for ignore files.

@alexey0308
Copy link

it looks like a duplicate #16200

@ccruquan
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants