Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: percentage based fee handler #194

Merged
merged 13 commits into from
Sep 1, 2023
Merged

feat: percentage based fee handler #194

merged 13 commits into from
Sep 1, 2023

Conversation

nmlinaric
Copy link
Contributor

Description

Introduces new fee handler that charges % from the transferred token amount.

Related Issue Or Context

Closes: #188

How Has This Been Tested? Testing details.

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/percentage-fee-handler branch from 280daae to e8ac31b Compare August 21, 2023 10:28
@nmlinaric nmlinaric force-pushed the nmlinaric/percentage-fee-handler branch from e8ac31b to 066b7e5 Compare August 21, 2023 11:31
@nmlinaric nmlinaric marked this pull request as ready for review August 21, 2023 11:45
@nmlinaric nmlinaric force-pushed the nmlinaric/percentage-fee-handler branch from 0b3e083 to 206037a Compare August 22, 2023 12:08
lastperson
lastperson requested changes Aug 28, 2023
View reviewed changes
@nmlinaric nmlinaric requested a review from lastperson August 29, 2023 08:53
@nmlinaric nmlinaric force-pushed the nmlinaric/percentage-fee-handler branch from 3a71d4f to aa6702f Compare August 31, 2023 10:48
@nmlinaric nmlinaric requested a review from mpetrun5 September 1, 2023 08:29
@nmlinaric nmlinaric merged commit 26dc82a into master Sep 1, 2023
@nmlinaric nmlinaric deleted the nmlinaric/percentage-fee-handler branch September 1, 2023 08:39
@mpetrun5 mpetrun5 mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastperson lastperson lastperson approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Percent based fee handler (EVM & substrate)
4 participants
@nmlinaric @lastperson @mpetrun5 @MakMuftic