Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Commit 17248d7

Browse files
committed
Update test with lowerBound > 0, upperBound = 0
1 parent 44e1b07 commit 17248d7

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

test/handlers/fee/percentage/calculateFee.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ contract("PercentageFeeHandler - [calculateFee]", async (accounts) => {
142142
assert.equal(res[0].toString(), "100");
143143
});
144144

145-
it("should return lower bound token amount for fee [lowerBound > 0, upperBound > 0]", async () => {
145+
it("should return lower bound token amount for fee [lowerBound > 0, upperBound = 0]", async () => {
146146
const depositData = Helpers.createERCDepositData(10000, 20, recipientAddress);
147-
await PercentageFeeHandlerInstance.changeFeeBounds(resourceID, 100, 300);
147+
await PercentageFeeHandlerInstance.changeFeeBounds(resourceID, 100, 0);
148148
await PercentageFeeHandlerInstance.changeFee(10000);
149149

150150
res = await FeeHandlerRouterInstance.calculateFee.call(

test/handlers/fee/percentage/changeFee.js

-11
Original file line numberDiff line numberDiff line change
@@ -125,17 +125,6 @@ contract("PercentageFeeHandler - [change fee and bounds]", async (accounts) => {
125125
);
126126
});
127127

128-
it("should fail to set lower bound larger than upper bound ", async () => {
129-
const PercentageFeeHandlerInstance = await PercentageFeeHandlerContract.new(
130-
BridgeInstance.address,
131-
FeeHandlerRouterInstance.address
132-
);
133-
await TruffleAssert.reverts(
134-
PercentageFeeHandlerInstance.changeFeeBounds(resourceID, 50, 25),
135-
"Upper bound must be larger than lower bound"
136-
);
137-
});
138-
139128
it("should set only lower bound", async () => {
140129
const newLowerBound = 30;
141130
const PercentageFeeHandlerInstance = await PercentageFeeHandlerContract.new(

0 commit comments

Comments
 (0)