-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Substrate Percentage Fee #297
Conversation
@MakMuftic the code for handling % based fees is here, both for EVM and substrate. No tests have been added yet. I've tested the getFee method with percentage fee handler on substrate side, but not EVM. Since I didn't have publish rights for the sygma-contracts npm package, I published a version under my own name space. Once this has been published correctly the import needs to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added a helper to fetch the fee type from the FeeRouter pallet.
Added logic to handle calculating the fee if the selected resource is configured to use the Percentage fee type.
Related Issue Or Context
Closes: #291
How Has This Been Tested? Testing details.
Fee is correctly calculated.
Tests were done on local env, with both min and max fee tested.
Types of changes
Checklist: