chore(substrate): add more substrate fungible tests (#423)

Closes #410

Author: Lykhoyda

.eslintrc.cjs

@@ -1,10 +1,5 @@
 module.exports = {
   root: true,
-  extends: [
-    "@chainsafe",
-    "plugin:require-extensions/recommended"
-  ],
-  plugins: [
-    "require-extensions"
-  ]
-}
+  extends: ["@chainsafe", "plugin:require-extensions/recommended"],
+  plugins: ["require-extensions"],
+};

examples/substrate-to-evm-fungible-transfer/tsconfig.json

@@ -1,21 +1,21 @@
 {
-	"compilerOptions": {
-		"composite": true,
-		"module": "ES2022",
-		"allowJs": true,
-		"declaration": true,
-		"sourceMap": true,
-		"declarationMap": true,
-		"resolveJsonModule": true,
-		"skipLibCheck": true,
-		"strict": true,
-		"esModuleInterop": true,
-		"downlevelIteration": true,
-		"allowSyntheticDefaultImports": true,
-		"forceConsistentCasingInFileNames": true,
-		"moduleResolution": "node",
-	},
-	"include": [
-		"src"
-	]
+  "compilerOptions": {
+    "composite": true,
+    "module": "ES2022",
+    "allowJs": true,
+    "declaration": true,
+    "sourceMap": true,
+    "declarationMap": true,
+    "resolveJsonModule": true,
+    "skipLibCheck": true,
+    "strict": true,
+    "esModuleInterop": true,
+    "downlevelIteration": true,
+    "allowSyntheticDefaultImports": true,
+    "forceConsistentCasingInFileNames": true,
+    "moduleResolution": "node"
+  },
+  "include": [
+    "src"
+  ]
 }

package.json

@@ -15,7 +15,7 @@
   "scripts": {
     "lint": "yarn workspaces foreach -A run lint",
     "clean": "yarn workspaces foreach -A run clean",
-    "build": "yarn run clean && yarn workspaces foreach -A run build:all",
+    "build": "yarn run clean && yarn workspaces foreach -A -t run build:all",
     "test": "yarn workspaces foreach -A run test:unit --ci --silent --coverage",
     "core:build": "yarn workspace @buildwithsygma/core build:all",
     "core:cleanDist": "yarn workspace @buildwithsygma/core clean",

packages/core/src/baseTransfer.ts

@@ -1,5 +1,5 @@
 import type { Config } from './config/config.js';
-import type { Domainlike, EvmResource, Domain, SubstrateResource } from './types.js';
+import type { Domain, Domainlike, EvmResource, SubstrateResource } from './types.js';
 
 export interface BaseTransferParams {
   source: Domainlike;
@@ -13,7 +13,6 @@ export abstract class BaseTransfer {
   protected sourceDomain: Domain;
   protected transferResource: EvmResource | SubstrateResource;
   protected sygmaConfiguration: Config;
-
   protected sourceAddress: string;
 
   public get source(): Domain {
@@ -78,8 +77,7 @@ export abstract class BaseTransfer {
    * @param destination
    * @returns
    */
-  setDesinationDomain(destination: Domainlike): void {
-    const domain = this.config.getDomain(destination);
-    this.destinationDomain = domain;
+  setDestinationDomain(destination: Domainlike): void {
+    this.destinationDomain = this.config.getDomain(destination);
   }
 }

packages/core/src/utils.ts

@@ -2,7 +2,7 @@ import * as process from 'node:process';
 
 import { decodeAddress, encodeAddress } from '@polkadot/keyring';
 import { hexToU8a, isHex } from '@polkadot/util';
-import validate, { Network as BitcoinNetwork } from 'bitcoin-address-validation';
+import { Network as BitcoinNetwork, validate } from 'bitcoin-address-validation';
 import { ethers } from 'ethers';
 
 import { ExplorerUrl, IndexerUrl } from './constants.js';

packages/evm/src/__test__/fungible.test.ts

@@ -344,4 +344,20 @@ describe('Fungible - Deposit', () => {
       'Insufficient ERC20 token balance',
     );
   });
+
+  it('should throw ERROR - Insufficient account balance', async () => {
+    (ERC20__factory.connect as jest.Mock).mockReturnValue({
+      balanceOf: jest.fn().mockResolvedValue(BigNumber.from(parseEther('1').toBigInt())), // Mock balance less than the required amount
+      populateTransaction: {
+        approve: jest.fn().mockResolvedValue({}),
+      },
+      allowance: jest.fn().mockResolvedValue(parseEther('0')),
+    });
+
+    const transfer = await createEvmFungibleAssetTransfer(TRANSFER_PARAMS);
+
+    await expect(transfer.getTransferTransaction()).rejects.toThrow(
+      'Insufficient ERC20 token balance',
+    );
+  });
 });