Skip to content

feat: fetch topology from ipfs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 23, 2022
Merged

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Nov 7, 2022

Fetch topology from http (IPFS) to avoid dependecy on storage and many variables that it needs.

Description

Related Issue Or Context

Closes: #31

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Go Test coverage is 64.1 %\ ✨ ✨ ✨

Copy link
Contributor

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpetrun5 Did we change these parameters on aws for our dev environment - this is necessary before we merge this. Apart from this, everything looks good.

@mpetrun5 mpetrun5 requested a review from P1sar November 22, 2022 14:46
@mpetrun5
Copy link
Collaborator Author

@mpetrun5 Did we change these parameters on aws for our dev environment - this is necessary before we merge this. Apart from this, everything looks good.

They are updated now.

@P1sar P1sar merged commit 8daa7e2 into main Nov 23, 2022
@mpetrun5 mpetrun5 deleted the mpetrun5/fetch-topology-from-ipfs branch January 4, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch topology from IPFS instead of Storage api
3 participants