Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update otlp sdk version and add metric tags #192

Merged
merged 7 commits into from
Jun 7, 2023

Conversation

P1sar
Copy link
Contributor

@P1sar P1sar commented Jun 6, 2023

  • version of OTLP bumped to the latest stable
  • some changes due to severe API upgrade of the OTLP SDK
  • refactored main metric structures

Description

Related Issue Or Context

Closes: #189

How Has This Been Tested? Testing details.

Tested locally with DataDog

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@P1sar P1sar marked this pull request as ready for review June 6, 2023 18:02
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Go Test coverage is 65.9 %\ ✨ ✨ ✨

docs/general/Metrics.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Go Test coverage is 65.9 %\ ✨ ✨ ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Go Test coverage is 65.7 %\ ✨ ✨ ✨

@P1sar P1sar merged commit ba919d6 into main Jun 7, 2023
@P1sar P1sar deleted the p1sar/add-tags-to-metrics branch June 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper env and service tags to relayers
3 participants