Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add relayerID and instance env to configuration to use in metrics #165

Merged
merged 4 commits into from
May 8, 2023
Merged

feat: add relayerID and instance env to configuration to use in metrics #165

merged 4 commits into from
May 8, 2023

Conversation

P1sar
Copy link
Contributor

@P1sar P1sar commented May 5, 2023

Description

ENV and RELAYER_ID env params containing current instance environment and RelayerID correspondingly, these variables are needed to distinguish metric names from each other

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 requested changes May 8, 2023
View reviewed changes
config/relayer/config.go Outdated Show resolved Hide resolved
config/env.go Outdated Show resolved Hide resolved
config/relayer/config.go Outdated Show resolved Hide resolved
@P1sar
feat: add relayerID and instance env to configuration to use in metrics
ad049a8 
add mapstructure to rawconfig, add tests, rename some config vars
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Go Test coverage is 66.0 %\ ✨ ✨ ✨

@P1sar P1sar requested a review from mpetrun5 May 8, 2023 15:10
mpetrun5
mpetrun5 requested changes May 8, 2023
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@P1sar
Copy link
Contributor Author

P1sar commented May 8, 2023

Merging with Admin privileges bcs in recent PR we have updated the test requirement for go 1.19 while here it is still 1.18

@P1sar P1sar merged commit d9c0860 into main May 8, 2023
@P1sar P1sar deleted the p1sar/add-env-and-relayer-id-to-config branch May 8, 2023 17:02
@MakMuftic MakMuftic mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@waymobetta waymobetta Awaiting requested review from waymobetta

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1sar @mpetrun5 @MakMuftic