Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track substrate extrinsic status #157

Merged
merged 7 commits into from
Apr 6, 2023
Merged

feat: track substrate extrinsic status #157

merged 7 commits into from
Apr 6, 2023

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Apr 5, 2023 •
edited
Loading

Track substrate extrinsic status so we now when it is finalized and if it successed or failed.

Description

Related Issue Or Context

Closes: #155
Closes: #154

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 requested review from tcar121293 and nmlinaric April 6, 2023 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

tcar121293
tcar121293 reviewed Apr 6, 2023
View reviewed changes
chains/substrate/util.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 requested a review from tcar121293 April 6, 2023 14:29
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@nmlinaric nmlinaric merged commit eee465c into main Apr 6, 2023
@nmlinaric nmlinaric deleted the mpetrun5/log-substrate-hash branch April 6, 2023 15:04
@MakMuftic MakMuftic mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcar121293 tcar121293 tcar121293 approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@waymobetta waymobetta Awaiting requested review from waymobetta

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log errors on proposal execution Log mpc signature of successful signing process
3 participants
@mpetrun5 @tcar121293 @nmlinaric