Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

fix: Switch from domainName to domainID #47

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Conversation

freddyli7
Copy link
Contributor

@freddyli7 freddyli7 commented Mar 29, 2023

Description

  • Switch from domainName to domainID in gas price fetching job
  • Removed impl of Polygonscan and merge gas oracle impl
  • config structure changes: introducing domain list with domainID into config
  • api service apikey in env var now is dynamic: gas price api service key format <SOURCE>_API_KEY_<DOMAIN_ID>, e.g: ETHERSCAN_API_KEY_0 if domain 0 is using etherscan to fetch gas price
  • conversion rate apikey in env var now is dynamic: conversion rate api service key format <SOURCE>_API_KEY. e.g: COINMARKETCAP_API_KEY

Related Issue Or Context

Closes: #24 #26

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@freddyli7 freddyli7 linked an issue Mar 29, 2023 that may be closed by this pull request
@freddyli7 freddyli7 linked an issue Apr 1, 2023 that may be closed by this pull request
@freddyli7 freddyli7 marked this pull request as ready for review April 3, 2023 18:01
config.yaml Outdated Show resolved Hide resolved
oracle/gasPriceOracle.go Outdated Show resolved Hide resolved
e2e/config/config.yaml Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@tcar121293 tcar121293 merged commit e88d862 into main Aug 23, 2023
@tcar121293 tcar121293 deleted the freddy/gas-price-domain branch August 23, 2023 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign gas price APIs per domain Filter gas price by domainID
4 participants