Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

fix: handle fetching conversion rate for same token #38

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

MakMuftic
Copy link
Contributor

This is a temporary addition to handle Goerli<>Sepolia case.

This case will be covered when we start refactoring these conversion pair definitions #34

Description

Related Issue Or Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@MakMuftic MakMuftic merged commit 4029375 into main Mar 15, 2023
@MakMuftic MakMuftic deleted the mmuftic/cover-same-base-currency-case branch March 15, 2023 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants