Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in conditional plugin due to latest changes related to promise resolution #46

Open
elboletaire opened this issue Mar 29, 2019 · 1 comment
Open

Error in conditional plugin due to latest changes related to promise resolution #46

elboletaire opened this issue Mar 29, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@elboletaire
Copy link
Member

This will need a bit of love to be properly fixed. The way we're handling the promises for the conditional plugin was causing issues for the tests, with the latest changes apparently everything was working but when we pushed to production there was obvious issues with the conditional plugin as it was continuing the execution despite it was failing some conditions.

This is happening only in version 2.2.1, version 2.2.0 works fine.
@elboletaire elboletaire added the bug Something isn't working label Mar 29, 2019
@elboletaire
Copy link
Member Author

This was reversed in 2.2.2 in order to be able to make other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elboletaire