Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to don't rely on aria-keyshortcuts #12

Closed
afercia opened this issue May 20, 2017 · 7 comments
Closed

Consider to don't rely on aria-keyshortcuts #12

afercia opened this issue May 20, 2017 · 7 comments

Comments

@afercia
Copy link

afercia commented May 20, 2017

aria-keyshortcuts is a new property available in ARIA 1.1, still a Candidate Recommendation.

While it doesn't harm, support is uncertain and it would be wise to don't rely on it as the only way to provide important information.

For reference:
https://www.w3.org/TR/wai-aria-1.1/#aria-keyshortcuts

@swissspidy
Copy link
Owner

Good to know, thanks! What would be a better way to communicate the available keyboard shortcuts?

@afercia
Copy link
Author

afercia commented May 21, 2017

Honestly I don't know :) The spec recommends exposing the shortcuts to all users:

Authors should provide a way to expose keyboard shortcuts so that all users may discover them, such as through the use of a tooltip.

However, the introduction of tooltips would probably be a bit controversial, even if TinyMCE is already using them.

I'd consider to add some general info about the new UI in the Help tab at the top of the page, that could include also some info about the shortcuts. It won't completely solve the issue, but could help.

I've initially considered aria-labels, for example:
<button aria-label="Move down (Alt+ArrowDown)" aria-keyshortcuts="Alt+ArrowDown" ... >Move Down</button>
but that would be redundant and would defeat the purpose of aria-keyshortcuts (when it will be supported). A while ago in an accessibility meeting, we were wondering about the need of a new "inline help system" but that would be definitely out of the scope of this project.

Unrelated:
I'd consider to add audible feedback when locales get added, moved up/down or removed, currently there's no feedback. For inspiration, the customizer already does something similar for menu items and widgets, see for example:
'Menu item moved up'
'Menu item moved down'
'Menu item added'
'Menu item deleted'
'Widget moved up'
etc.
This should go in a separate issue, of course :)

@swissspidy
Copy link
Owner

I am still deciding between tooltips and a general help text. @afercia Are there any new suggestions nowadays by the a11y team?

@swissspidy
Copy link
Owner

Unfortunately there's no documentation on Exposing and Documenting Keyboard Shortcuts.

@afercia
Copy link
Author

afercia commented Oct 4, 2017

Yep it's still in the making...
No news from me. While some visually hidden text inside the buttons may help assistive technologies users, that wouldn't communicate the available shortcuts visually. Maybe a general help text is the best option for now?

@swissspidy
Copy link
Owner

@swissspidy
Copy link
Owner

I think I am going with tooltips for now until this gets better support in core itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants