Hooks on forwarded requests

[mcweba]

Consider the following routing rules:

{
	"/gateleen/resources/v1/(.*)": {
		"path": "/gateleen/other/resources/v1/$1"
	},
	"/gateleen/other/resources/v1/(.*)": {
		"path": "/gateleen/somewhere/else/$1"
	}
}

A master routing rule (/gateleen/resources/v1/(.*) which forwards to another rule (/gateleen/other/resources/v1/(.*)).

When hooks for both URLs are created, the second hook (to /gateleen/other/resources/v1/(.*)) will never be triggered because of the x-hooked request header added by the HookHandler class.

The HookHandler checks whether a request is already hooked with

/**
 * Checks if the original Request was already hooked.
 * Eg. After a request is processed by the hook handler
 * (register), the handler creates a self request with
 * a copy of the original request. Therefore it's
 * necessary to mark the request as already hooked.
 *
 * @param request request
 * @return true if the original request was already hooked.
 */
public boolean isRequestAlreadyHooked(HttpServerRequest request) {
	String hooked = request.headers().get(HOOKED_HEADER);
	return hooked != null && hooked.equals("true");
}

When forwarding a request, the original request headers are copied to the new client request. I am not sure whether we should also copy the x-hooked request header.

@ljucam I assigned it to you, since you are the master of the hooks :-)

[mushtaq96]

Hello @mcweba is this issue still open and require any help?