Skip to content

feat(styles): update stepper#1646

Merged
imagoiq merged 15 commits into
mainfrom
1636-styles-update-stepper
Aug 10, 2023
Merged

feat(styles): update stepper#1646
imagoiq merged 15 commits into
mainfrom
1636-styles-update-stepper

Conversation

@imagoiq

@imagoiq imagoiq commented Jul 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Here are the fixes from #1636

@imagoiq imagoiq self-assigned this Jul 20, 2023
@changeset-bot

changeset-bot Bot commented Jul 20, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a80f695

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@swisspost/design-system-demo Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation-v7 Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot

swisspost-bot commented Jul 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1646--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1646--swisspost-design-system-next-v7.netlify.app
Preview environment ready: https://preview-1646--swisspost-design-system-next.netlify.app

@imagoiq imagoiq linked an issue Jul 20, 2023 that may be closed by this pull request
Styles: Update Stepper #1636
Closed
gfellerph
gfellerph requested changes Jul 27, 2023
View reviewed changes
Comment thread .changeset/rare-kids-drum.md

@gfellerph gfellerph Jul 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could combine both changesets so people know which component is concerned.

@alizedebray alizedebray Jul 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was me who asked to separate the changeset because it seems strange to me to have "clarified how to use the stepper" in the styles changelog... But it is true that the second changelog does not specify which component is affected by the changes.

@imagoiq imagoiq Jul 27, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a convention for the context, or is it fine like this?

Comment thread packages/demo/src/app/post-sample/components/stepper/stepper-demo/stepper-demo.component.html Outdated
alizedebray
alizedebray requested changes Jul 27, 2023
View reviewed changes
Comment thread packages/styles/src/components/stepper.scss Outdated
alizedebray
alizedebray requested changes Aug 7, 2023
View reviewed changes

@alizedebray alizedebray left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this criteria is no longer met when using a a tag for the 4th step: "Set background color black to interactive next step badge on hover (currently only the label is changed)"

@imagoiq

imagoiq commented Aug 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It seems that this criteria is no longer met when using a a tag for the 4th step: "Set background color black to interactive next step badge on hover (currently only the label is changed)"

Yes, sorry. We discussed it at some meeting and decided to disable interactivity on the steps after the current step. So this is not anymore valid. I've updated the tasklist.

@imagoiq imagoiq requested a review from alizedebray August 7, 2023 08:05
alizedebray
alizedebray approved these changes Aug 10, 2023
View reviewed changes
Comment thread .changeset/rare-kids-drum.md Outdated
Comment thread .changeset/rare-kids-drum.md Outdated
@imagoiq @alizedebray
Update .changeset/rare-kids-drum.md
7b6728f 
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
@imagoiq @alizedebray
Update .changeset/rare-kids-drum.md
a80f695 
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 10, 2023

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud

sonarqubecloud Bot commented Aug 10, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imagoiq imagoiq merged commit 600687d into main Aug 10, 2023
@imagoiq imagoiq deleted the 1636-styles-update-stepper branch August 10, 2023 09:02
@github-actions github-actions Bot mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfellerph gfellerph gfellerph approved these changes

@alizedebray alizedebray alizedebray approved these changes

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

Assignees

@imagoiq imagoiq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Styles: Update Stepper

4 participants

@imagoiq @swisspost-bot @gfellerph @alizedebray