Skip to content

fix(header): added bigger logo with animation#1552

Merged
gfellerph merged 16 commits into
mainfrom
1529-header-test-new-logo-animation
Aug 11, 2023
Merged

fix(header): added bigger logo with animation#1552
gfellerph merged 16 commits into
mainfrom
1529-header-test-new-logo-animation

Conversation

@gfellerph

@gfellerph gfellerph commented Jun 21, 2023

Copy link
Copy Markdown
Member

As per request from branding, the logo should be the topmost element on the page. To handle the disappearing meta-navigation, the logo animation was introduced.

@gfellerph
fix(header): added logo animation
48d8d35 
As per request from branding, the logo should be the topmost element on the page. To handle the disappearing meta-navigation, the logo animation was introduced.
@gfellerph gfellerph linked an issue Jun 21, 2023 that may be closed by this pull request
Header: test new logo animation #1529
Closed
@changeset-bot

changeset-bot Bot commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b81c909

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@swisspost/internet-header Minor
@swisspost/design-system-documentation-v7 Patch
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot

swisspost-bot commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1552--swisspost-design-system-next.netlify.app
Preview environment ready: https://preview-1552--swisspost-design-system-next-v7.netlify.app

@swisspost-bot

swisspost-bot commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1552--swisspost-design-system-next.netlify.app

2 similar comments
@swisspost-bot

swisspost-bot commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1552--swisspost-design-system-next.netlify.app

@swisspost-bot

swisspost-bot commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1552--swisspost-design-system-next.netlify.app

@swisspost-bot

swisspost-bot commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1552--swisspost-design-system-next.netlify.app

1 similar comment
@swisspost-bot

swisspost-bot commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1552--swisspost-design-system-next.netlify.app

@gfellerph gfellerph marked this pull request as ready for review June 21, 2023 14:30
@gfellerph gfellerph requested review from rouvenpost and wueestd June 21, 2023 14:34
alizedebray
alizedebray approved these changes Jun 22, 2023
View reviewed changes
Comment thread packages/internet-header/src/components/post-internet-header/logo-animation/logo-animation.ts
Comment thread .changeset/stupid-pianos-rush.md Outdated
Comment thread packages/internet-header/src/components/post-internet-header/logo-animation/logo-animation.scss
Comment thread packages/internet-header/src/components/post-internet-header/post-internet-header.tsx
@gfellerph @alizedebray
Update .changeset/stupid-pianos-rush.md
e1d7a5d 
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
@gfellerph gfellerph marked this pull request as draft June 27, 2023 11:35
@gfellerph gfellerph marked this pull request as ready for review July 3, 2023 14:54
@gfellerph gfellerph requested a review from imagoiq as a code owner July 3, 2023 14:54
oliverschuerch
oliverschuerch requested changes Jul 5, 2023
View reviewed changes

@oliverschuerch oliverschuerch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When having the header in the full-sticky mode, with meta navigation enabled and scrolling through the page, the logo animation is executed as well.
This needs to be fixed, because the animation is not necessary then.

Comment thread packages/internet-header/src/components/post-internet-header/logo-animation/logo-animation.ts
Comment thread packages/internet-header/src/components/post-meta-navigation/post-meta-navigation.scss
gfellerph and others added 2 commits July 5, 2023 09:18
@gfellerph
Update packages/internet-header/src/components/post-meta-navigation/p…
65e6423 
…ost-meta-navigation.scss

Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
@gfellerph
fix: prevent animation in full stickyness mode
f55ab59
@oliverschuerch

oliverschuerch commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

@gfellerph The logo works correctly, but the animation behaviour is not updated correctly within the documentation, when a user switches the stickyness.
Maybe it could help, to trigger a window resize event or something, whenever the story is rerendered.

gfellerph and others added 2 commits August 2, 2023 14:51
@gfellerph
Merge branch 'main' into 1529-header-test-new-logo-animation
e8e528f
@gfellerph
fix: handle dynamically changing stickyness
3fdfcc8 
Logo animation state is being updated whenever stickyness changes on the fly.
@gfellerph

gfellerph commented Aug 2, 2023

Copy link
Copy Markdown
Member Author

@gfellerph The logo works correctly, but the animation behaviour is not updated correctly within the documentation, when a user switches the stickyness. Maybe it could help, to trigger a window resize event or something, whenever the story is rerendered.

done @oliverschuerch

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph merged commit 2baa121 into main Aug 11, 2023
@gfellerph gfellerph deleted the 1529-header-test-new-logo-animation branch August 11, 2023 05:14
@github-actions github-actions Bot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@alizedebray alizedebray alizedebray approved these changes

@rouvenpost rouvenpost Awaiting requested review from rouvenpost

@wueestd wueestd Awaiting requested review from wueestd

@imagoiq imagoiq Awaiting requested review from imagoiq

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Header: test new logo animation

4 participants

@gfellerph @swisspost-bot @oliverschuerch @alizedebray