fix(styles): clean up alert and toast styles#1350
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1dd35c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alizedebray
changed the title
Contributor
|
Preview environment ready: https://preview-1350--swisspost-web-frontend.netlify.app |
oliverschuerch
requested changes
Apr 28, 2023
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
…into 352-clean-up-alerttoast-styles
alizedebray
commented
May 3, 2023
Contributor
There was a problem hiding this comment.
@alizedebray The default story in the storybook alert component should have the new alert-gray variant as well.
# Conflicts: # packages/styles/src/components/alert.scss # packages/styles/src/components/utilities.scss
alizedebray
force-pushed
the
352-clean-up-alerttoast-styles
branch
from
c47c350 to
7e27337
Compare
gfellerph
requested changes
Aug 9, 2023
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
oliverschuerch
approved these changes
Aug 9, 2023
gfellerph
approved these changes
Aug 14, 2023
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.