Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global header has wrong padding right #4728

Open
sandra-post opened this issue Feb 20, 2025 · 1 comment · May be fixed by #4767
Open

Global header has wrong padding right #4728

sandra-post opened this issue Feb 20, 2025 · 1 comment · May be fixed by #4767
Assignees
Labels
🐞 bug Something isn't working Header Everything related to our composible header components
Milestone

Comments

@sandra-post
Copy link

sandra-post commented Feb 20, 2025

(Viewport: Tablet and Mobile)

IS

Local header has padding right 16px.

SHOULD

Local header should have padding right of 4px, so that link elements in global and local header are vertically aligned.

Image


@sandra-post sandra-post added the Header Everything related to our composible header components label Feb 20, 2025
@sandra-post sandra-post added the 🐞 bug Something isn't working label Feb 20, 2025
@gfellerph gfellerph added this to the PPNL Support milestone Feb 20, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Feb 24, 2025
@gfellerph
Copy link
Member

Align paddings of global and local header to the same values for all viewports and remove inline margins from local header components.

Global and local header content should be aligned on the same line to the left and right.

@leagrdv leagrdv self-assigned this Feb 24, 2025
@leagrdv leagrdv moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Feb 24, 2025
@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working Header Everything related to our composible header components
Projects
Status: 🤬 Dev in Code Review
3 participants