Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gap left and right of main navigation #4722

Open
sandra-post opened this issue Feb 20, 2025 · 0 comments · May be fixed by #4767
Open

Remove gap left and right of main navigation #4722

sandra-post opened this issue Feb 20, 2025 · 0 comments · May be fixed by #4767
Assignees
@leagrdv
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components
Milestone
PPNL Support

Comments

@sandra-post
Copy link

sandra-post commented Feb 20, 2025 •
edited
Loading

(Viewport: Desktop)

IS

There is a 4px gap on the left and right in the main navigation, which has initially been added to make space for the focus ring of the first nav element.

SHOULD

After discussion with @gfellerph some time ago, we have decided to remove it again, also to align nav element label to title and logo.

Image
@sandra-post sandra-post added the Header Everything related to our composible header components label Feb 20, 2025
@gfellerph gfellerph added this to the PPNL Support milestone Feb 20, 2025
@sandra-post sandra-post mentioned this issue Feb 20, 2025
Closed
@sandra-post sandra-post added the 🐞 bug Something isn't working label Feb 20, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Feb 20, 2025
@gfellerph gfellerph added the 📦 components Related to the @swisspost/design-system-components package label Feb 20, 2025
@gfellerph gfellerph moved this from 💻 Ready for development to 👀 Triage in Design System Production Board Feb 20, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Feb 24, 2025
@leagrdv leagrdv self-assigned this Feb 24, 2025
@leagrdv leagrdv moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Feb 24, 2025
@leagrdv leagrdv linked a pull request Feb 24, 2025 that will close this issue
fix(components,styles): post-header margins and global buttons shrink on scroll #4767
Open
@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leagrdv leagrdv

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components
Projects
Design System Production Board
Status: 🤬 Dev in Code Review
Milestone
PPNL Support
3 participants
@gfellerph @sandra-post @leagrdv