Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internet Header logo animation does not work outside of an iFrame in Storybook #1825

Closed
gfellerph opened this issue Aug 17, 2023 · 3 comments
Closed

Internet Header logo animation does not work outside of an iFrame in Storybook #1825

gfellerph opened this issue Aug 17, 2023 · 3 comments
Labels
📦 documentation Related to the @swisspost/design-system-documentation package 📦 internet-header Related to the @swisspost/internet-header package on hold Wait for something to be done, before continue working on this Issue

Comments

@gfellerph
Copy link
Member 

          I used `ArgTypes` instead of `Controls` here because currently [controls don't work on iframe demos](https://github.com/storybookjs/storybook/issues/11908), but an iframe is needed for the logo animation to work properly.

Originally posted by @alizedebray in #1822 (comment)

Find a solution for the header logo animation to work without an iframe or the controls to work with the iframe.
@gfellerph gfellerph changed the title I used ArgTypes instead of Controls here because currently [controls don't work on iframe demos](https://github.com/storybookjs/storybook/issues/11908), but an iframe is needed for the logo animation to work properly. Internet Header logo animation does not work outside of an iFrame in Storybook Aug 17, 2023
@gfellerph gfellerph added 📦 documentation Related to the @swisspost/design-system-documentation package 📦 internet-header Related to the @swisspost/internet-header package on hold Wait for something to be done, before continue working on this Issue labels Aug 17, 2023
@gfellerph
Copy link
Member Author

gfellerph commented Aug 23, 2023 •
edited by alizedebray
Loading

On hold until internet header stories are done (#1855)

@oliverschuerch
Copy link
Contributor

Probably already fixed, check #1855

@gfellerph
Copy link
Member Author

Closing as fixed

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Design System Production Board Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 documentation Related to the @swisspost/design-system-documentation package 📦 internet-header Related to the @swisspost/internet-header package on hold Wait for something to be done, before continue working on this Issue
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfellerph @oliverschuerch