Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grid behavior #1225

Closed
4 tasks done
Tracked by #2032
gfellerph opened this issue Mar 6, 2023 · 3 comments · Fixed by #2045
Closed
4 tasks done
Tracked by #2032

Update grid behavior #1225

gfellerph opened this issue Mar 6, 2023 · 3 comments · Fixed by #2045
Assignees
Labels
📦 styles Related to the @swisspost/design-system-styles package

Comments

@gfellerph
Copy link
Member

gfellerph commented Mar 6, 2023

Synchronize the grid implementation with the Design. See the grid analysis issue for details and the history of the discussion.

Design: https://www.figma.com/file/ojCcgC5Zd12eUSzq6V5m24/Foundations?t=S9MdGWrTM9E4Kyob-0

Gutter width comparison

Viewport Design Implementation1
XXS (<400) Gutter: 12
Margin: 12
Gutter: 30
Margin: 12
XS (400-600) Gutter: 12
Margin: 16
Gutter: 30
Margin: 16
S (600-800) Gutter: 16
Margin: 32
Gutter: 30
Margin: 32
M (800-1024) Gutter: 16
Margin: 32
Gutter: 30
Margin: 32
L (1024-1280) Gutter: 16
Margin: 40
Gutter: 30
Margin: 40
XL (>1280) Gutter: 16
Margin: 0
Fixed column width of 84
Gutter: 30
Margin: 128
Container max width: 1440

Tasks

Preview Give feedback
  1. pibs 📦 styles
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Mar 6, 2023
@gfellerph gfellerph added this to the Design - Implementation Sync milestone Mar 6, 2023
@gfellerph
Copy link
Member Author

Discuss with Design again, when going from 1023 to 1024 content shrinks as well. Could we use vw padding?

@gfellerph gfellerph added the 💭 draft Issue is not ready for development label Mar 13, 2023
@gfellerph gfellerph added the next label Aug 9, 2023
@oliverschuerch
Copy link
Contributor

oliverschuerch commented Sep 19, 2023

As far as I know, every person included in the decision approved our intention, visualized here: https://design-system-grid-visualization.netlify.app/.
Source: https://github.com/swisspost/design-system-grid-visualization

@gfellerph Can we go on and work on this issue?

@oliverschuerch oliverschuerch self-assigned this Oct 3, 2023
@oliverschuerch oliverschuerch moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Oct 3, 2023
@oliverschuerch oliverschuerch moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Oct 4, 2023
@oliverschuerch oliverschuerch removed the 💭 draft Issue is not ready for development label Oct 4, 2023
@oliverschuerch oliverschuerch linked a pull request Oct 4, 2023 that will close this issue
@oliverschuerch oliverschuerch moved this from 🏗 In progress to 👀 In review in Design System Production Board Oct 5, 2023
@oliverschuerch
Copy link
Contributor

Final adjunstments

Element Property XS SM RG MD LG XL XXL
.container padding-inline 12px 16px 16px 32px 32px 40px 120px
.container-fluid padding-inline 12px 16px 16px 32px 32px 32px 32px
.row / .col gutter 12px 16px 16px 16px 16px 16px 16px

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Development

Successfully merging a pull request may close this issue.

2 participants