Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontawesome 5 (Pro?) support broken #638

Closed
reFX-Mike opened this issue May 7, 2018 · 6 comments
Closed

Fontawesome 5 (Pro?) support broken #638

reFX-Mike opened this issue May 7, 2018 · 6 comments

Comments

@reFX-Mike
Copy link

When using the CSS/webfont for FontAwesome 5.0 (I've used Pro, but it might affect the non-pro version as well), the icons do not show up at all.

I've managed to supply a function that returns the correct class names, but then the icons have a large margin/padding on the left and the menu-item text itself loses its font and looks like some old school font with sarifs.

@LeonGreeff
Copy link

LeonGreeff commented May 11, 2018

I have the same issue. I will come back to you if I have found a solution.

@bbrala
Copy link
Member

bbrala commented May 11, 2018

I wonder what the best solution would be. The current setup is really just adding an class to the item.

Perhaps the best option would be another icon setting (iconHtml?) in which you can put a bit of html. Which enables things like <i class='fas fas-confirm'></i>. And would enable usage of different icons. Especially since Fa5 now also supplies SVG alongside the old font approach.

@wimZ
Copy link

wimZ commented Jun 14, 2018

Same issue here. The fa icons show huge.

Fontawesome has a shim js, but that does not solve it.

Fal;ling back to native icons for now

@dschueler
Copy link

same here...FA BROKEN ..all good in the rest of my page..NOT good in context menu

2018-06-23_08-41-31

@BrennickL
Copy link

We recently upgraded to FontAwesome 5 Pro and all Icons are broken. As mentioned above the icon sets for fa, fal, and fab icons are no longer displaying. Unable to fallback to previous version of FontAwesome. Looking for a work-around to fix the problem.

@bbrala
Copy link
Member

bbrala commented Jul 10, 2018

This issue is is a duplicatie of #593, i've created a branch with a fix for Font Awesome 5 support.

@bbrala bbrala closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants