fix: don't send target temp range form old state if heat cool mode is off

Fixes #299

Author: =

custom_components/dual_smart_thermostat/managers/environment_manager.py

@@ -24,6 +24,7 @@
     CONF_DRY_TOLERANCE,
     CONF_FAN_HOT_TOLERANCE,
     CONF_FLOOR_SENSOR,
+    CONF_HEAT_COOL_MODE,
     CONF_HOT_TOLERANCE,
     CONF_MAX_FLOOR_TEMP,
     CONF_MAX_HUMIDITY,
@@ -110,6 +111,7 @@ def __init__(self, hass: HomeAssistant, config: ConfigType):
         self._cur_outside_temp = None
         self._cur_humidity = None
         self._saved_target_humidity = None
+        self._config_heat_cool_mode = config.get(CONF_HEAT_COOL_MODE) or False
 
     @property
     def cur_temp(self) -> float:
@@ -789,14 +791,16 @@ def apply_old_state(self, old_state: State) -> None:
         if old_state is None:
             return
 
+        _LOGGER.debug("Old state attributes: %s", old_state.attributes)
+
         # If we have no initial temperature, restore
-        if self._target_temp_low is None:
+        if self._target_temp_low is None and self._config_heat_cool_mode:
             old_target_min = old_state.attributes.get(
                 ATTR_PREV_TARGET_LOW
             ) or old_state.attributes.get(ATTR_TARGET_TEMP_LOW)
             if old_target_min is not None:
                 self._target_temp_low = float(old_target_min)
-        if self._target_temp_high is None:
+        if self._target_temp_high is None and self._config_heat_cool_mode:
             old_target_max = old_state.attributes.get(
                 ATTR_PREV_TARGET_HIGH
             ) or old_state.attributes.get(ATTR_TARGET_TEMP_HIGH)

tests/__init__.py

@@ -748,6 +748,34 @@ async def setup_comp_heat_cool_2(hass: HomeAssistant) -> None:
     await hass.async_block_till_done()
 
 
+@pytest.fixture
+async def setup_comp_heat_cool_3(hass: HomeAssistant) -> None:
+    """Initialize components."""
+    hass.config.units = METRIC_SYSTEM
+    assert await async_setup_component(
+        hass,
+        CLIMATE,
+        {
+            "climate": {
+                "platform": DOMAIN,
+                "name": "test",
+                "cold_tolerance": 2,
+                "hot_tolerance": 4,
+                "heater": common.ENT_HEATER,
+                "cooler": common.ENT_COOLER,
+                "target_sensor": common.ENT_SENSOR,
+                "initial_hvac_mode": HVACMode.HEAT_COOL,
+                "target_temp": 21,
+                "heat_cool_mode": False,
+                PRESET_AWAY: {
+                    "temperature": 16,
+                },
+            }
+        },
+    )
+    await hass.async_block_till_done()
+
+
 @pytest.fixture
 async def setup_comp_dual_fan_config(hass: HomeAssistant) -> None:
     """Initialize components."""

tests/test_dual_mode.py

@@ -392,6 +392,55 @@ async def test_get_hvac_modes_heat_cool_2(
     )
 
 
+# async def test_get_hvac_modes_heat_cool_if_heat_cool_mode_off(
+#     hass: HomeAssistant, setup_comp_heat_cool_3  # noqa: F811
+# ) -> None:
+#     """Test that the operation list returns the correct modes."""
+#     await async_setup_component(
+#         hass,
+#         CLIMATE,
+#         {
+#             "climate": {
+#                 "platform": DOMAIN,
+#                 "name": "test",
+#                 "cold_tolerance": 2,
+#                 "hot_tolerance": 4,
+#                 "heater": common.ENT_HEATER,
+#                 "cooler": common.ENT_COOLER,
+#                 "target_sensor": common.ENT_SENSOR,
+#                 "initial_hvac_mode": HVACMode.OFF,
+#                 "target_temp": 21,
+#                 "heat_cool_mode": False,
+#                 PRESET_AWAY: {
+#                     "temperature": 16,
+#                 },
+#             }
+#         },
+#     )
+#     await hass.async_block_till_done()
+
+#     common.mock_restore_cache(
+#         hass,
+#         (
+#             State(
+#                 common.ENTITY,
+#                 {
+#                     ATTR_PREV_TARGET_HIGH: "21",
+#                     ATTR_PREV_TARGET_LOW: "19",
+#                 },
+#             ),
+#         ),
+#     )
+
+#     hass.set_state(CoreState.starting)
+#     await hass.async_block_till_done()
+
+#     state = hass.states.get(common.ENTITY)
+#     assert state.attributes.get("supported_features") == 401
+#     modes = state.attributes.get("hvac_modes")
+#     assert set(modes) == set([HVACMode.OFF, HVACMode.HEAT, HVACMode.COOL])
+
+
 async def test_dual_get_hvac_modes_fan_configured(
     hass: HomeAssistant, setup_comp_dual_fan_config  # noqa: F811
 ) -> None: